Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1560881

Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue

From Jesper Dangaard Brouer <brouer@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue
Date 2017-01-17 19:10 +0100
Message-ID <t0GmL-1VI-29@gated-at.bofh.it> (permalink)
References <t0ypb-5hh-5@gated-at.bofh.it> <t0ypc-5hh-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 17 Jan 2017 09:29:51 +0000 Mel Gorman <mgorman@techsingularity.net> wrote:

> +/* Lock and remove page from the per-cpu list */
> +static struct page *rmqueue_pcplist(struct zone *preferred_zone,
> +			struct zone *zone, unsigned int order,
> +			gfp_t gfp_flags, int migratetype)
> +{
> +	struct per_cpu_pages *pcp;
> +	struct list_head *list;
> +	bool cold = ((gfp_flags & __GFP_COLD) != 0);
> +	struct page *page;
> +	unsigned long flags;
> +
> +	local_irq_save(flags);
> +	pcp = &this_cpu_ptr(zone->pageset)->pcp;
> +	list = &pcp->lists[migratetype];
> +	page = __rmqueue_pcplist(zone,  migratetype, cold, pcp, list);
> +	if (page) {
> +		__count_zid_vm_events(PGALLOC, page_zonenum(page), 1 << order);
> +		zone_statistics(preferred_zone, zone, gfp_flags);

Word-of-warning: The zone_statistics() call changed number of
parameters in commit 41b6167e8f74 ("mm: get rid of __GFP_OTHER_NODE").
(Not sure what tree you are based on)

> +	}
> +	local_irq_restore(flags);
> +	return page;
> +}


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] Use per-cpu allocator for !irq requests and prepare for a bulk allocator v4 Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 10:40 +0100
  [PATCH 2/4] mm, page_alloc: Split alloc_pages_nodemask Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 10:40 +0100
  [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 10:40 +0100
    Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Jesper Dangaard Brouer <brouer@redhat.com> - 2017-01-17 19:10 +0100
      Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 21:40 +0100
        Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 22:10 +0100
          Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Vlastimil Babka <vbabka@suse.cz> - 2017-01-17 22:30 +0100
  [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue context Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 10:40 +0100
    Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Vlastimil Babka <vbabka@suse.cz> - 2017-01-20 15:30 +0100
      Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Mel Gorman <mgorman@techsingularity.net> - 2017-01-20 16:40 +0100
        Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Petr Mladek <pmladek@suse.com> - 2017-01-23 17:30 +0100
          Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Mel Gorman <mgorman@techsingularity.net> - 2017-01-23 18:00 +0100
        Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Tejun Heo <tj@kernel.org> - 2017-01-23 18:10 +0100
          Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Mel Gorman <mgorman@techsingularity.net> - 2017-01-23 21:10 +0100
            Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Tejun Heo <tj@kernel.org> - 2017-01-23 22:00 +0100
              Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Mel Gorman <mgorman@techsingularity.net> - 2017-01-24 00:10 +0100
                Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Tejun Heo <tj@kernel.org> - 2017-01-24 17:10 +0100
                Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Mel Gorman <mgorman@techsingularity.net> - 2017-01-25 01:00 +0100
                Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Tejun Heo <tj@kernel.org> - 2017-01-25 03:10 +0100
                Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Mel Gorman <mgorman@techsingularity.net> - 2017-01-25 09:40 +0100
    Re: [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue  context Vlastimil Babka <vbabka@suse.cz> - 2017-01-24 12:10 +0100
  [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for irq-safe requests Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 10:40 +0100
    Re: [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for  irq-safe requests Vlastimil Babka <vbabka@suse.cz> - 2017-01-20 16:10 +0100
      Re: [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for  irq-safe requests Mel Gorman <mgorman@techsingularity.net> - 2017-01-23 12:20 +0100

csiph-web