Re: [PATCH 7/8] slab: remove synchronous synchronize_sched() from memcg cache deactivation path

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] slab: remove synchronous synchronize_sched() from memcg cache deactivation path
Date	2017-01-17 18:00 +0100
Message-ID	<t0Fh0-12w-17@gated-at.bofh.it> (permalink)
References	<sZBIu-XU-5@gated-at.bofh.it> <sZBIv-XU-31@gated-at.bofh.it> <t0pYB-8gp-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 17, 2017 at 09:26:11AM +0900, Joonsoo Kim wrote:
> > +	INIT_WORK(&s->memcg_params.deact_work, kmemcg_deactivate_workfn);
> > +	schedule_work(&s->memcg_params.deact_work);
> > +}
> 
> Isn't it better to submit one work item for each memcg like as
> Vladimir did? Or, could you submit this work to the ordered workqueue?
> I'm not an expert about workqueue like as you, but, I think
> that there is a chance to create a lot of threads if there is
> the slab_mutex lock contention.

Yeah, good point.  I'll switch it to its own workqueue w/ concurrency
limited to one.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 7/8] slab: remove synchronous synchronize_sched() from  memcg cache deactivation path Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2017-01-17 01:40 +0100
  Re: [PATCH 7/8] slab: remove synchronous synchronize_sched() from  memcg cache deactivation path Tejun Heo <tj@kernel.org> - 2017-01-17 18:00 +0100

csiph-web