Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560714

[PATCH 13/13] MIPS: avoid old-style declaration

Show all headers | View raw

gcc warns about nonstandard declarations:

arch/mips/sgi-ip32/ip32-irq.c:31:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
arch/mips/sgi-ip32/ip32-irq.c:36:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
arch/mips/sgi-ip27/ip27-klnuma.c: In function 'replicate_kernel_text':
arch/mips/sgi-ip27/ip27-klnuma.c:85:116: error: old-style function definition [-Werror=old-style-definition]

Moving 'inline' before the return type, and adding argument types
shuts up the warning here. This patch affects several platforms,
but all in a trivial way. I'm fixing up all instances I found in
any of the 'defconfig' builds.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/mips/emma/markeins/setup.c  | 2 +-
 arch/mips/netlogic/xlp/wakeup.c  | 2 +-
 arch/mips/sgi-ip27/ip27-klnuma.c | 2 +-
 arch/mips/sgi-ip32/ip32-irq.c    | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/mips/emma/markeins/setup.c b/arch/mips/emma/markeins/setup.c
index 9100122e5cef..44ff64a80255 100644
--- a/arch/mips/emma/markeins/setup.c
+++ b/arch/mips/emma/markeins/setup.c
@@ -90,7 +90,7 @@ void __init plat_time_init(void)
 static void markeins_board_init(void);
 extern void markeins_irq_setup(void);
 
-static void inline __init markeins_sio_setup(void)
+static inline void __init markeins_sio_setup(void)
 {
 }
 
diff --git a/arch/mips/netlogic/xlp/wakeup.c b/arch/mips/netlogic/xlp/wakeup.c
index 87d7846af2d0..d61004dd71b4 100644
--- a/arch/mips/netlogic/xlp/wakeup.c
+++ b/arch/mips/netlogic/xlp/wakeup.c
@@ -197,7 +197,7 @@ static void xlp_enable_secondary_cores(const cpumask_t *wakeup_mask)
 	}
 }
 
-void xlp_wakeup_secondary_cpus()
+void xlp_wakeup_secondary_cpus(void)
 {
 	/*
 	 * In case of u-boot, the secondaries are in reset
diff --git a/arch/mips/sgi-ip27/ip27-klnuma.c b/arch/mips/sgi-ip27/ip27-klnuma.c
index bda90cf87e8c..2beb03907d09 100644
--- a/arch/mips/sgi-ip27/ip27-klnuma.c
+++ b/arch/mips/sgi-ip27/ip27-klnuma.c
@@ -82,7 +82,7 @@ static __init void copy_kernel(nasid_t dest_nasid)
 	memcpy((void *)dest_kern_start, (void *)source_start, kern_size);
 }
 
-void __init replicate_kernel_text()
+void __init replicate_kernel_text(void)
 {
 	cnodeid_t cnode;
 	nasid_t client_nasid;
diff --git a/arch/mips/sgi-ip32/ip32-irq.c b/arch/mips/sgi-ip32/ip32-irq.c
index e0c7d9e142fa..838d8589a1c0 100644
--- a/arch/mips/sgi-ip32/ip32-irq.c
+++ b/arch/mips/sgi-ip32/ip32-irq.c
@@ -28,12 +28,12 @@
 #include <asm/ip32/ip32_ints.h>
 
 /* issue a PIO read to make sure no PIO writes are pending */
-static void inline flush_crime_bus(void)
+static inline void flush_crime_bus(void)
 {
 	crime->control;
 }
 
-static void inline flush_mace_bus(void)
+static inline void flush_mace_bus(void)
 {
 	mace->perif.ctrl.misc;
 }
-- 
2.9.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/13] MIPS: fix modversions Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100
  [PATCH 03/13] MIPS: 'make -s' should be silent Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100
  [PATCH 10/13] MIPS: loongson64: fix empty-body warning in dma_alloc Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100
  [PATCH 06/13] MIPS: Lantiq: Fix another request_mem_region() return code check Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100
  [PATCH 09/13] MIPS: ralink: remove unused rt*_wdt_reset functions Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100
  [PATCH 13/13] MIPS: avoid old-style declaration Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100
  [PATCH 02/13] MIPS: VDSO: avoid duplicate CAC_BASE definition Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100
  [PATCH 12/13] MIPS: ip22: fix ip28 build for modern gcc Arnd Bergmann <arnd@arndb.de> - 2017-01-17 16:30 +0100

csiph-web