Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1560694
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM |
| Date | 2017-01-17 16:20 +0100 |
| Message-ID | <t0DIe-fW-17@gated-at.bofh.it> (permalink) |
| References | <t0gBX-1Cr-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jan 16, 2017 at 3:30 PM, Augusto Mecking Caringi
<augustocaringi@gmail.com> wrote:
> The only usage of function intel_gpio_runtime_idle() is here (in the
> same file):
>
> static const struct dev_pm_ops intel_gpio_pm_ops = {
> SET_RUNTIME_PM_OPS(NULL, NULL, intel_gpio_runtime_idle)
> };
>
> And when CONFIG_PM is not set, the macro SET_RUNTIME_PM_OPS expands to
> nothing, causing the following compiler warning:
>
> drivers/gpio/gpio-intel-mid.c:324:12: warning: ‘intel_gpio_runtime_idle’
> defined but not used [-Wunused-function]
> static int intel_gpio_runtime_idle(struct device *dev)
>
> Fix it by annotating the function with __maybe_unused.
>
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
Patch applied with Andy's ACK.
Yours,
Linus Walleij
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] gpio: intel-mid: Fix build warning when !CONFIG_PM Linus Walleij <linus.walleij@linaro.org> - 2017-01-17 16:20 +0100
csiph-web