Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560603

Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected)

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected)
Date 2017-01-17 15:00 +0100
Message-ID <t0CsO-7MA-35@gated-at.bofh.it> (permalink)
References (2 earlier) <sYq2K-6QF-13@gated-at.bofh.it> <sYA25-4n7-11@gated-at.bofh.it> <sYK1s-2hi-23@gated-at.bofh.it> <sZMDT-7Go-1@gated-at.bofh.it> <t0dkL-817-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon 16-01-17 11:09:34, Mel Gorman wrote:
[...]
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 532a2a750952..46aac487b89a 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2684,6 +2684,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
>  				continue;
>  
>  			if (sc->priority != DEF_PRIORITY &&
> +			    !buffer_heads_over_limit &&
>  			    !pgdat_reclaimable(zone->zone_pgdat))
>  				continue;	/* Let kswapd poll it */

I think we should rather remove pgdat_reclaimable here. This sounds like
a wrong layer to decide whether we want to reclaim and how much.

But even that won't help very much I am afraid. As I've noted in the
other response as long as we will scale the slab shrinking based on
nr_scanned we will have a problem with situations where slab outnumbers
lru lists too much. I do not have a good idea how to fix that though...

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-17 15:00 +0100
  Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-17 15:30 +0100
    Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-17 16:00 +0100
      Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Trevor Cordes <trevor@tecnopolis.ca> - 2017-01-18 08:30 +0100
      Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-18 18:50 +0100
      Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-18 19:10 +0100
      Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Trevor Cordes <trevor@tecnopolis.ca> - 2017-01-19 10:50 +0100
        Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-19 12:40 +0100
          Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Trevor Cordes <trevor@tecnopolis.ca> - 2017-01-20 07:40 +0100
            Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-20 12:10 +0100
              Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-20 17:00 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-23 11:50 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-23 12:10 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-25 10:50 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-24 14:00 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Trevor Cordes <trevor@tecnopolis.ca> - 2017-01-25 11:30 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-25 13:10 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Trevor Cordes <trevor@tecnopolis.ca> - 2017-01-30 00:00 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-30 09:00 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Mel Gorman <mgorman@techsingularity.net> - 2017-01-30 10:20 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-24 14:00 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Trevor Cordes <trevor@tecnopolis.ca> - 2017-01-27 00:20 +0100
                Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-27 08:40 +0100
            Re: mm, vmscan: commit makes PAE kernel crash nightly (bisected) Michal Hocko <mhocko@kernel.org> - 2017-01-24 14:00 +0100

csiph-web