Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare
Date	2017-01-17 14:50 +0100
Message-ID	<t0Cj7-7Jg-1@gated-at.bofh.it> (permalink)
References	<sWKRY-8g7-37@gated-at.bofh.it> <sWLbl-8oT-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 6 Jan 2017, Vikas Shivappa wrote:
> @@ -741,7 +741,13 @@ static int intel_cqm_event_init(struct perf_event *event)
>  	INIT_LIST_HEAD(&event->hw.cqm_group_entry);
>  	INIT_LIST_HEAD(&event->hw.cqm_groups_entry);
>  
> -	event->destroy = intel_cqm_event_destroy;

I missed this in the first round, but tripped over it when looking at one
of the follow up patches.

How is that supposed to work?

1) intel_cqm_event_destroy() is still in the code and unused which emits a
   compiler warning, but that can obviously be ignored for a good measure.

2) How would any testing of this mess actually work?

   Not all all. Nothing ever tears down an event. So you just leave
   everything hanging around probably with dangling pointers left and
   right.

So now the 'Tests: Same as before.' in the so called changelog makes sense:

   'Same as before' means: Completely untested and broken.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Thomas Gleixner <tglx@linutronix.de> - 2017-01-17 14:50 +0100
  Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Shivappa Vikas <vikas.shivappa@intel.com> - 2017-01-17 21:30 +0100
    Re: [PATCH 05/12] x86/cqm,perf/core: Cgroup support prepare Thomas Gleixner <tglx@linutronix.de> - 2017-01-17 22:40 +0100

csiph-web