Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1560636
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands |
| Date | 2017-01-17 15:30 +0100 |
| Message-ID | <t0CVQ-8bo-15@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <sURkS-2H5-33@gated-at.bofh.it> <sUSgV-3hC-5@gated-at.bofh.it> <sWs8G-3cr-11@gated-at.bofh.it> <t0lLk-5zl-15@gated-at.bofh.it> <t0CM9-88g-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jan 17, 2017 at 07:43:51PM +0530, Sreekanth Reddy wrote: > [Sreekanth] Just for readability purpose, can use use "if (test_bit(0, > &sas_device_priv_data->ata_command_pending)" > instead of "if (sas_device_priv_data->ata_command_pending)". > Since while setting & clearing the bit we are using atomic bit > operations. I don't see any issue functionality wise. I agree. Also while we're into nitpicking - it would be good to give bit 0 of the bitmap a name instead of hardcoding the 0. Except for these patch looks fine: Reviewed-by: Christoph Hellwig <hch@lst.de>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-16 21:10 +0100
Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-01-16 22:10 +0100
Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands Ingo Molnar <mingo@kernel.org> - 2017-01-17 10:30 +0100
Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands Sreekanth Reddy <sreekanth.reddy@broadcom.com> - 2017-01-17 15:20 +0100
Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands Christoph Hellwig <hch@lst.de> - 2017-01-17 15:30 +0100
Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-01-17 22:00 +0100
Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-17 15:50 +0100
csiph-web