Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1560558
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT |
| Date | 2017-01-17 13:40 +0100 |
| Message-ID | <t0Bdn-768-3@gated-at.bofh.it> (permalink) |
| References | <sQISR-8ka-3@gated-at.bofh.it> <sQISS-8ka-33@gated-at.bofh.it> <t0kme-4kY-19@gated-at.bofh.it> <t0zlh-5WC-39@gated-at.bofh.it> <t0AU1-6Zd-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jan 17, 2017 at 06:18:12AM -0600, Timur Tabi wrote:
> Fu Wei wrote:
> >if (i >= ARCH_TIMER_MEM_MAX_FRAMES) {
> > pr_err(FW_BUG "too many frames, ARMv8 spec only allows 8.\n");
>
> pr_err(FW_BUG "too many frames, ARMv8 spec only allows %u.\n",
> ARCH_TIMER_MEM_MAX_FRAMES);
While I don't see ARCH_TIMER_MEM_MAX_FRAMES changing, this would be
nicer to ensure the result obviously matches.
As for wording, I'd perfer:
pr_err(FW_BUG "too many frames, only %u are permitted.\n",
ARCH_TIMER_MEM_MAX_FRAMES);
... so as to avoid any confusion between spec versions and so on. We can
reconsider the message if/when that changes.
Thanks,
Mark.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT Fu Wei <fu.wei@linaro.org> - 2017-01-17 11:40 +0100
Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT Fu Wei <fu.wei@linaro.org> - 2017-01-17 11:50 +0100
Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT Timur Tabi <timur@codeaurora.org> - 2017-01-17 13:20 +0100
Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT Mark Rutland <mark.rutland@arm.com> - 2017-01-17 13:40 +0100
Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT Fu Wei <fu.wei@linaro.org> - 2017-01-17 14:30 +0100
csiph-web