Re: [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c
Date	2017-01-17 12:30 +0100
Message-ID	<t0A7E-6t2-23@gated-at.bofh.it> (permalink)
References	<t0fwd-WM-3@gated-at.bofh.it> <t0fwd-WM-1@gated-at.bofh.it> <t0mxI-5SC-17@gated-at.bofh.it> <t0zXY-6py-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 17 January 2017 12:08:09 Pavel Machek wrote:
> Hi!
> 
> > Thanks for the patch set.
> > 
> > Would you mind fixing also the following issues raised by
> > checkpatch.pl?:
> > 
> > WARNING: Missing a blank line after declarations
> > #376: FILE: drivers/platform/x86/dell-wmi-led.c:64:
> > +	struct bios_args args;
> ...
> > The fixes could be placed in an incremental patch after this one.
> 
> Anyway, move itself is ok (and the checkpatch issues are not that serious anyway.)
> 
> Thanks,
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Yes, this patch does not change code, just move one file to other
location. You can add my Reviewed-by.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 6/6] dell-led: move driver to  drivers/platform/x86/dell-wmi-led.c Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-01-16 22:00 +0100
  Re: [PATCH v2 6/6] dell-led: move driver to  drivers/platform/x86/dell-wmi-led.c Pavel Machek <pavel@ucw.cz> - 2017-01-17 12:20 +0100
    Re: [PATCH v2 6/6] dell-led: move driver to  drivers/platform/x86/dell-wmi-led.c Pali Rohár <pali.rohar@gmail.com> - 2017-01-17 12:30 +0100

csiph-web