Re: [PATCH V2 6/6] gpio: davinci: Remove redundant macros

From	Keerthy <j-keerthy@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 6/6] gpio: davinci: Remove redundant macros
Date	2017-01-16 08:00 +0100
Message-ID	<t09qN-4Xd-11@gated-at.bofh.it> (permalink)
References	<sZ1EZ-4HH-1@gated-at.bofh.it> <sZ1F0-4HH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Linus,

On Friday 13 January 2017 09:50 AM, Keerthy wrote:
> Some of the macros were needed as per old driver design.
> With the current implementation they are unwanted. Hence remove
> them.

Seems like Macros are being used in:
arch/arm/mach-davinci/board-neuros-osd2.c

So this patch can be dropped from the series.

>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  include/linux/platform_data/gpio-davinci.h | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h
> index 90ae19c..f922601 100644
> --- a/include/linux/platform_data/gpio-davinci.h
> +++ b/include/linux/platform_data/gpio-davinci.h
> @@ -45,14 +45,6 @@ struct davinci_gpio_controller {
>  	unsigned int		base;
>  };
>
> -/*
> - * basic gpio routines
> - */
> -#define	GPIO(X)		(X)	/* 0 <= X <= (DAVINCI_N_GPIO - 1) */
> -
> -/* Convert GPIO signal to GPIO pin number */
> -#define GPIO_TO_PIN(bank, gpio)	(16 * (bank) + (gpio))
> -
>  static inline u32 __gpio_mask(unsigned gpio)
>  {
>  	return 1 << (gpio % 32);
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 6/6] gpio: davinci: Remove redundant macros Keerthy <j-keerthy@ti.com> - 2017-01-13 05:30 +0100
  Re: [PATCH V2 6/6] gpio: davinci: Remove redundant macros kbuild test robot <lkp@intel.com> - 2017-01-15 05:40 +0100
  Re: [PATCH V2 6/6] gpio: davinci: Remove redundant macros Keerthy <j-keerthy@ti.com> - 2017-01-16 08:00 +0100

csiph-web