Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559458

Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

Show all headers | View raw

On 13/01/17 18:55, Remanan Pillai wrote:
> From: Vineeth Remanan Pillai <vineethp@amazon.com>
> 
> During an OOM scenario, request slots could not be created as skb
> allocation fails. So the netback cannot pass in packets and netfront
> wrongly assumes that there is no more work to be done and it disables
> polling. This causes Rx to stall.
> 
> The issue is with the retry logic which schedules the timer if the
> created slots are less than NET_RX_SLOTS_MIN. The count of new request
> slots to be pushed are calculated as a difference between new req_prod
> and rsp_cons which could be more than the actual slots, if there are
> unconsumed responses.
> 
> The fix is to calculate the count of newly created slots as the
> difference between new req_prod and old req_prod.
> 
> Signed-off-by: Vineeth Remanan Pillai <vineethp@amazon.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Thanks,

Juergen

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] xen-netfront: Fix Rx stall during network stress and OOM Vineeth Remanan Pillai <vineethp@amazon.com> - 2017-01-12 00:20 +0100
  Re: [PATCH] xen-netfront: Fix Rx stall during network stress and  OOM David Miller <davem@davemloft.net> - 2017-01-12 21:20 +0100
    Re: [PATCH] xen-netfront: Fix Rx stall during network stress and OOM Vineeth Remanan Pillai <vineethp@amazon.com> - 2017-01-13 00:20 +0100
      Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and  OOM Juergen Gross <jgross@suse.com> - 2017-01-16 07:30 +0100

csiph-web