Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559375

Re: [PATCH] ahci: imx: fix building without hwmon or thermal

Show all headers | View raw

On Wed, Jan 11, 2017 at 02:36:16PM +0100, Arnd Bergmann wrote:
> When CONFIG_HWMON is disabled, we now get a link failure:
> 
> ERROR: "devm_hwmon_device_register_with_groups" [drivers/ata/ahci_imx.ko] undefined!
> drivers/ata/ahci_imx.o: In function `imx_ahci_probe':
> ahci_imx.c:(.text.imx_ahci_probe+0x304): undefined reference to `devm_thermal_zone_of_sensor_register'
> 
> This makes the code calling into the hwmon subsystem compile-time
> conditional, and adds a Kconfig dependency to avoid the corner
> case of having HWMON=m and AHCI_IMX=y, by forcing AHCI_IMX=m in this
> case. The thermal subsystem already has a check in its header, but
> that also doesn't cover the THERMAL=m case, so we need a somewhat
> complex Kconfig expression to handle all cases.
> 
> Fixes: 54643a83b41a ("ahci: imx: Add imx53 SATA temperature sensor support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to libata/for-4.11.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ahci: imx: fix building without hwmon or thermal Arnd Bergmann <arnd@arndb.de> - 2017-01-11 14:40 +0100
  Re: [PATCH] ahci: imx: fix building without hwmon or thermal Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-01-11 15:20 +0100
  Re: [PATCH] ahci: imx: fix building without hwmon or thermal Tejun Heo <tj@kernel.org> - 2017-01-16 01:00 +0100

csiph-web