Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1514694

Re: [PATCH] drm/amd/powerplay: return false instead of -EINVAL

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 03/11/16 17:39, Deucher, Alexander wrote:
>> Returning -EINVAL from a bool-returning function
>> phm_check_smc_update_required_for_display_configuration has an
>> unexpected
>> effect of returning true, which is probably not what was intended.
>> Replace -EINVAL by false.
>>
>> The only place this function is called from is
>> psm_adjust_power_state_dynamic in
>> drivers/gpu/drm/amd/powerplay/eventmgr/psm.c:106:
>>
>> 	if (!equal ||
>> phm_check_smc_update_required_for_display_configuration(hwmgr)) {
>> 		phm_apply_state_adjust_rules(hwmgr, requested,
>> pcurrent);
>> 		phm_set_power_state(hwmgr, &pcurrent->hardware,
>> &requested->hardware);
>> 		hwmgr->current_ps = requested;
>> 	}
>>
>> It seems to expect a boolean value here.
>>
>> This issue has been found using the following Coccinelle semantic patch
>> written by Peter Senna Tschudin:
>> <smpl>
>> @@
>> identifier f;
>> constant C;
>> typedef bool;
>> @@
>> bool f (...){
>> <+...
>> * return -C;
>> ...+>
>> }
>> </smpl>
>>
>> Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
> 
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> 
> I'll pick this up shortly. Thanks!

Great, thanks! I wonder who should I prod for this one:
https://patchwork.kernel.org/patch/7206081/

-- 
Cheers,
  Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/amd/powerplay: return false instead of -EINVAL Andrew Shadura <andrew.shadura@collabora.co.uk> - 2016-11-03 11:10 +0100
  RE: [PATCH] drm/amd/powerplay: return false instead of -EINVAL "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-11-03 17:50 +0100
  Re: [PATCH] drm/amd/powerplay: return false instead of -EINVAL Andrew Shadura <andrew.shadura@collabora.co.uk> - 2016-11-03 17:50 +0100
  RE: [PATCH] drm/amd/powerplay: return false instead of -EINVAL "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2016-11-03 18:00 +0100

csiph-web