Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1514626

[PATCH 1/2] drm/i915: Remove redundant reprobe in i915_drm_resume

Show all headers | View raw

Weine's investigation on benchmarking the suspend/resume process pointed
out a lot of the time in suspend/resume is being spent reprobing. While
the reprobing process is a lengthy one for good reason, we don't need to
hold up the entire suspend/resume process while we wait for it to
finish. Luckily as it turns out, we already trigger a full connector
reprobe in i915_hpd_poll_init_work(), so we can just ditch reprobing in
i915_drm_resume() entirely.

This won't lead to less time spent resuming just yet since now the
bottleneck will be waiting for the mode_config lock in
drm_kms_helper_poll_enable(), since that will be held as long as
i915_hpd_poll_init_work() is reprobing all of the connectors. But we'll
address that in the next patch.

Signed-off-by: Lyude <lyude@redhat.com>
Cc: David Weinehall <david.weinehall@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index bfb2efd..532cc0f 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1602,8 +1602,6 @@ static int i915_drm_resume(struct drm_device *dev)
 	 * notifications.
 	 * */
 	intel_hpd_init(dev_priv);
-	/* Config may have changed between suspend and resume */
-	drm_helper_hpd_irq_event(dev);
 
 	intel_opregion_register(dev_priv);
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drm/i915: Remove redundant reprobe in i915_drm_resume Lyude <lyude@redhat.com> - 2016-11-03 16:50 +0100
  Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in  i915_drm_resume Chris Wilson <chris@chris-wilson.co.uk> - 2016-11-03 17:10 +0100
    Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in  i915_drm_resume Lyude Paul <cpaul@redhat.com> - 2016-11-03 17:20 +0100
      Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in  i915_drm_resume Chris Wilson <chris@chris-wilson.co.uk> - 2016-11-03 17:30 +0100
        Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in  i915_drm_resume Lyude Paul <cpaul@redhat.com> - 2016-11-03 17:50 +0100
    Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in  i915_drm_resume Lyude Paul <cpaul@redhat.com> - 2016-11-03 17:20 +0100
  Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove redundant reprobe in  i915_drm_resume David Weinehall <tao@kernel.org> - 2016-11-03 20:00 +0100

csiph-web