Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1514640
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements) |
| Date | 2016-11-03 17:00 +0100 |
| Message-ID | <szsAO-5Mg-9@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <szds6-4tX-9@gated-at.bofh.it> <szds6-4tX-11@gated-at.bofh.it> <szds6-4tX-13@gated-at.bofh.it> <szds6-4tX-15@gated-at.bofh.it> <szds5-4tX-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi, Sorry for not chipping in earlier - LPC is taking my time. > > > > Looks like we are missing a kfree(family->attrbuf); on error > > > > path, but it is not related to Johannes' recent patches. Actually, I think it *is* related to my patch - I inserted the code there in the wrong place or so. I'll find a fix for that when I'm back home, or you (Cong) can submit yours. It wasn't likely that this was the problem though, since that's just an error path that should never happen (we have <30 genl families, and a 16-bit space for their IDs) > I realized that kmemleak is not scanning the __ro_after_init > section... > Following patch solves the false positives but I wonder if it's the > right/acceptable solution. Hah, makes sense to me, but I guess we really want Catalin to comment :) johannes
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements) Jakub Kicinski <kubakici@wp.pl> - 2016-11-03 00:50 +0100 Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements) Cong Wang <xiyou.wangcong@gmail.com> - 2016-11-03 06:50 +0100 Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements) Johannes Berg <johannes@sipsolutions.net> - 2016-11-03 17:00 +0100 Re: [RFC] make kmemleak scan __ro_after_init section (was: Re: [PATCH 0/5] genetlink improvements) Catalin Marinas <catalin.marinas@arm.com> - 2016-11-03 21:50 +0100
csiph-web