Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1514522
| From | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 1/2] usb: gadget: mv_u3d: add check for dma mapping error |
| Date | 2016-11-03 14:20 +0100 |
| Message-ID | <szq5X-4mP-9@gated-at.bofh.it> (permalink) |
| References | <szm2m-1A3-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
mv_u3d_req_to_trb() does not check for dma mapping errors.
Found by Linux Driver Verification project (linuxtesting.org).
v2: split fix and clenup to separate patches.
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/usb/gadget/udc/mv_u3d_core.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c
index b9e19a591322..6f3be0ba9ac8 100644
--- a/drivers/usb/gadget/udc/mv_u3d_core.c
+++ b/drivers/usb/gadget/udc/mv_u3d_core.c
@@ -462,6 +462,12 @@ static int mv_u3d_req_to_trb(struct mv_u3d_req *req)
req->trb_head->trb_hw,
trb_num * sizeof(*trb_hw),
DMA_BIDIRECTIONAL);
+ if (dma_mapping_error(u3d->gadget.dev.parent,
+ req->trb_head->trb_dma)) {
+ kfree(req->trb_head->trb_hw);
+ kfree(req->trb_head);
+ return -EFAULT;
+ }
req->chain = 1;
}
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: gadget: mv_u3d: add check for dma mapping error Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-10-29 01:20 +0200
Re: [PATCH] usb: gadget: mv_u3d: add check for dma mapping error Felipe Balbi <balbi@kernel.org> - 2016-11-03 10:00 +0100
[PATCH v2 2/2] usb: gadget: mv_u3d: mv_u3d_start_queue() refactoring Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-11-03 14:20 +0100
[PATCH v2 1/2] usb: gadget: mv_u3d: add check for dma mapping error Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-11-03 14:20 +0100
Re: [PATCH v2 1/2] usb: gadget: mv_u3d: add check for dma mapping error Felipe Balbi <balbi@kernel.org> - 2016-11-03 14:40 +0100
Re: [PATCH v2 1/2] usb: gadget: mv_u3d: add check for dma mapping error Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-11-03 19:10 +0100
csiph-web