Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver

From	Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver
Date	2016-11-03 11:40 +0100
Message-ID	<sznB7-2Ga-3@gated-at.bofh.it> (permalink)
References	<sz1hf-56k-5@gated-at.bofh.it> <szlJ0-1tA-15@gated-at.bofh.it> <sz1hf-56k-25@gated-at.bofh.it> <szlJ0-1tA-13@gated-at.bofh.it> <sznhL-2zZ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/03/2016 11:10 AM, Andi Shyti wrote:
> Hi Jacek,
>
>> Only DT bindings of LED class drivers should be placed in
>> Documentation/devicetree/bindings/leds. Please move it to the
>> media bindings.
>
> that's where I placed it first, but Rob asked me to put it in the
> LED directory and Cc the LED mailining list.
>
> That's the discussion of the version 2:
>
> https://lkml.org/lkml/2016/9/12/380
>
> Rob, Jacek, could you please agree where I can put the binding?

I'm not sure if this is a good approach. I've noticed also that
backlight bindings have been moved to leds, whereas they don't look
similarly.

We have common.txt LED bindings, that all LED class drivers' bindings
have to follow. Neither backlight bindings nor these ones do that,
which introduces some mess.

Eventually adding a sub-directory, e.g. remote_control could make it
somehow logically justified, but still - shouldn't bindings be
placed in the documentation directory related to the subsystem of the
driver they are predestined to?

-- 
Best regards,
Jacek Anaszewski

Thread

[PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi  device driver Andi Shyti <andi.shyti@samsung.com> - 2016-11-02 11:50 +0100
  Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-03 09:40 +0100
    Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Andi Shyti <andi.shyti@samsung.com> - 2016-11-03 11:20 +0100
      Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-03 11:40 +0100
        Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Andi Shyti <andi.shyti@samsung.com> - 2016-11-04 05:30 +0100
        Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Rob Herring <robh@kernel.org> - 2016-11-09 19:30 +0100
          Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-11-10 08:50 +0100
            Re: [PATCH v3 5/6] Documentation: bindings: add documentation for  ir-spi device driver Andi Shyti <andi.shyti@samsung.com> - 2016-11-10 11:10 +0100

csiph-web