Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family

From	joeyli <jlee@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family
Date	2016-11-03 05:20 +0100
Message-ID	<szhFn-7jx-1@gated-at.bofh.it> (permalink)
References	<syz1D-3My-7@gated-at.bofh.it> <szhcl-6S9-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 03, 2016 at 11:40:15AM +0800, Anthony Wong wrote:
> On 1 November 2016 at 12:30, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote:
> >
> > The AMW0_GUID1 wmi is not only found on Acer family but also other
> > machines like Lenovo, Fujitsu and Medion. In the past days, acer-wmi
> > driver handled those non-Acer machines by quirks list.
> >
> > But actually acer-wmi driver was loaded on any machines that have
> > AMW0_GUID1. This behavior is strange because those machines should
> > be supported by appropriate wmi drivers. e.g. fujitsu-laptop,
> > ideapad-laptop.
> >
> > So, This patch adds the logic to check the machine that has AMW0_GUID1
> > should be in Acer/Packard Bell/Gateway white list. But, it still keeps
> > the quirk list of those supported non-acer machines for backward
> > compatible.
> >
> > Tested-by: Bjørn Mork <bjorn@mork.no>
> > Cc: Darren Hart <dvhart@infradead.org>
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> 
> Xiaomi Air 13.3 notebook suffers from the same issue, acer-wmi
> basically has no use on this machine. With your patch, acer-wmi no
> longer loads.
> 
> Tested-by: Anthony Wong <anthony@ypwong.org>
> 
> Thanks,
> Anthony

Thanks for your testing!
Joey Lee

Thread

[PATCH] acer-wmi: only supports AMW0_GUID1 on acer family "Lee, Chun-Yi" <joeyli.kernel@gmail.com> - 2016-11-01 05:40 +0100
  Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family Anthony Wong <ypwong@gmail.com> - 2016-11-03 04:50 +0100
    Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family joeyli <jlee@suse.com> - 2016-11-03 05:20 +0100
    Re: [PATCH] acer-wmi: only supports AMW0_GUID1 on acer family Darren Hart <dvhart@infradead.org> - 2016-11-05 19:30 +0100

csiph-web