Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1514122

[PATCH] e1000e: free IRQ when the link is up or down

Show all headers | View raw

Move IRQ free code so that it will happen regardless of the
link state. Currently the e1000e driver only releases its IRQ
if the link is up. This is not sufficient because it is
possible for a link to go down without releasing the IRQ. A
secondary bus reset can cause this case to happen.

Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 7017281..36cfcb0 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -4679,12 +4679,13 @@ int e1000e_close(struct net_device *netdev)
 
 	if (!test_bit(__E1000_DOWN, &adapter->state)) {
 		e1000e_down(adapter, true);
-		e1000_free_irq(adapter);
 
 		/* Link status message must follow this format */
 		pr_info("%s NIC Link is Down\n", adapter->netdev->name);
 	}
 
+	e1000_free_irq(adapter);
+
 	napi_disable(&adapter->napi);
 
 	e1000e_free_tx_resources(adapter->tx_ring);
-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] e1000e: free IRQ when the link is up or down Tyler Baicar <tbaicar@codeaurora.org> - 2016-11-02 22:10 +0100
  Re: [PATCH] e1000e: free IRQ when the link is up or down Alexander Duyck <alexander.duyck@gmail.com> - 2016-11-02 22:50 +0100
  RE: [Intel-wired-lan] [PATCH] e1000e: free IRQ when the link is up  or     down "Ruinskiy, Dima" <dima.ruinskiy@intel.com> - 2016-11-03 09:20 +0100
    Re: [Intel-wired-lan] [PATCH] e1000e: free IRQ when the link is up or  down "Baicar, Tyler" <tbaicar@codeaurora.org> - 2016-11-03 17:00 +0100

csiph-web