Re: [PATCH] MIPS: VDSO: Always select -msoft-float

From	"Maciej W. Rozycki" <macro@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MIPS: VDSO: Always select -msoft-float
Date	2016-11-04 17:10 +0100
Message-ID	<szPe1-40v-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <syQ2t-6iF-1@gated-at.bofh.it> <syQOR-6OD-1@gated-at.bofh.it> <szMg9-1OG-1@gated-at.bofh.it> <szN2x-2k4-17@gated-at.bofh.it> <szOBj-3x3-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 4 Nov 2016, Guenter Roeck wrote:

> > As above, unless absolutely critical to have floating point code then
> > the vDSO should just avoid all FP related issues and build soft-float.
> 
> FWIW, my logic was quite simple: The rest of the kernel builds with
> -msoft-float, thus vDSO should do the same. Of course, I don't know the
> entire context, so there may well be a reason to handle it differently
> than the rest of the kernel.

 VDSO is not a part of the kernel, it's user mode code, made visible in 
the user virtual memory, and implicitly loaded along the rest of the DSOs 
on program startup by the dynamic loader (ld.so).  It has to be PIC for 
that reason, too, causing all the hassle we had with making it such that 
it does not need a GOT.

> Anyway, isn't the kernel supposed to not use floating point operations
> in the first place ? Is this different for vDSO ?

 This code is executed in the user mode so while floating-point code may 
not be needed there, not at least right now, there's actually nothing 
which should stop us from from adding some should such a need arise.

  Maciej

Thread

[PATCH] MIPS: VDSO: Always select -msoft-float Guenter Roeck <linux@roeck-us.net> - 2016-10-30 17:10 +0100
  Re: [PATCH] MIPS: VDSO: Always select -msoft-float "Maciej W. Rozycki" <macro@imgtec.com> - 2016-11-01 23:50 +0100
    Re: [PATCH] MIPS: VDSO: Always select -msoft-float Guenter Roeck <linux@roeck-us.net> - 2016-11-02 00:40 +0100
      Re: [PATCH] MIPS: VDSO: Always select -msoft-float "Maciej W. Rozycki" <macro@imgtec.com> - 2016-11-04 14:00 +0100
        RE: [PATCH] MIPS: VDSO: Always select -msoft-float Matthew Fortune <Matthew.Fortune@imgtec.com> - 2016-11-04 14:50 +0100
          Re: [PATCH] MIPS: VDSO: Always select -msoft-float Guenter Roeck <linux@roeck-us.net> - 2016-11-04 16:30 +0100
            Re: [PATCH] MIPS: VDSO: Always select -msoft-float "Maciej W. Rozycki" <macro@imgtec.com> - 2016-11-04 17:10 +0100
              RE: [PATCH] MIPS: VDSO: Always select -msoft-float Matthew Fortune <Matthew.Fortune@imgtec.com> - 2016-11-04 18:00 +0100
                Re: [PATCH] MIPS: VDSO: Always select -msoft-float Guenter Roeck <linux@roeck-us.net> - 2016-11-04 19:40 +0100
                RE: [PATCH] MIPS: VDSO: Always select -msoft-float "Maciej W. Rozycki" <macro@imgtec.com> - 2016-11-04 20:10 +0100
              Re: [PATCH] MIPS: VDSO: Always select -msoft-float Guenter Roeck <linux@roeck-us.net> - 2016-11-04 18:00 +0100
                Re: [PATCH] MIPS: VDSO: Always select -msoft-float "Maciej W. Rozycki" <macro@imgtec.com> - 2016-11-04 19:10 +0100

csiph-web