Re: [PATCH 3/5] block: move poll code to blk-mq

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] block: move poll code to blk-mq
Date	2016-11-04 15:50 +0100
Message-ID	<szNYC-342-33@gated-at.bofh.it> (permalink)
References	<szwbn-8dS-11@gated-at.bofh.it> <szwbn-8dS-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 03, 2016 at 01:45:05PM -0600, Jens Axboe wrote:
> The poll code is blk-mq specific, let's move it to blk-mq.c. This
> is a prep patch for improving the polling code.
> 
> Signed-off-by: Jens Axboe <axboe@fb.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

So I gave my ok earlier, but I spent some more time looking at this
this morning and now I wonder why we even bother to keep some
code in blk-core.c.  How about just renaming the whole damn thing
to blk_mq_poll and move it to blk-mq.c instead of that split?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] block: move poll code to blk-mq Jens Axboe <axboe@fb.com> - 2016-11-03 20:50 +0100
  Re: [PATCH 3/5] block: move poll code to blk-mq Christoph Hellwig <hch@lst.de> - 2016-11-04 15:50 +0100

csiph-web