Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input()

From	Hans Verkuil <hverkuil@xs4all.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input()
Date	2016-11-04 09:10 +0100
Message-ID	<szHJv-7wH-11@gated-at.bofh.it> (permalink)
References	<srsHD-5Fa-11@gated-at.bofh.it> <srtaG-5Pq-19@gated-at.bofh.it> <szpjz-3NI-33@gated-at.bofh.it> <szxqO-KH-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/11/16 22:05, SF Markus Elfring wrote:
>>> @@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv,
>>>          return -EINVAL;
>>>      }
>>>      sdinfo = &vpfe_dev->cfg->sub_devs[subdev];
>>> -    memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input));
>>> +    memcpy(inp, &sdinfo->inputs[index], sizeof(*inp));
>>
>> If I am not mistaken this can be written as:
>>
>>     *inp = sdinfo->inputs[index];
>>
>> Much better.
>
> At which position would you like to integrate a second approach for such a change
> from this patch series?
>
> * Do you expect me to send a "V2" for the whole series?

No, just for the patches I commented upon.

>
> * Will an update step be appropriate if I would rebase it on other
>   recently accepted suggestions?

You can base it on 
https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v4.10a

That branch has all your other patches of this series merged and is part 
of a pull
request I posted yesterday.

	Hans

>
> Regards,
> Markus
>

Thread

Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size  determination in vpfe_enum_input() Hans Verkuil <hverkuil@xs4all.nl> - 2016-11-03 13:30 +0100
  Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size  determination in vpfe_enum_input() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-11-03 22:10 +0100
    Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size  determination in vpfe_enum_input() Hans Verkuil <hverkuil@xs4all.nl> - 2016-11-04 09:10 +0100
      [PATCH v2 17/34] [media] DaVinci-VPFE-Capture: Replace a memcpy()  call by an assignment in vpfe_enum_input() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-11-06 22:10 +0100

csiph-web