Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1514960

Re: [PATCH] clk: rockchip: fix some clocks' name to be more standard style

Show all headers | View raw

Hi Heiko and Shawn:

ok, I agree with you, and the root fix seems to fix it in the TRM first.
I'll feedback to TRM makers.

Thanks.

On 2016年11月03日 22:32, Heiko Stübner wrote:
> Am Donnerstag, 3. November 2016, 16:52:48 schrieb Shawn Lin:
>> On 2016/11/2 15:04, Jianqun Xu wrote:
>>> Fix aclk_emmcgrf to aclk_emmc_grf, and fix aclk_emmccore to be
>>> aclk_emmc_core.
>>
>> What is the standard style should be?
>>
>> TRM uses aclk_emmccore but not aclk_emmc_core, so should it be more
>> standrad to keep it as-is?
>
> I tend to agree with Shawn. While it looks like the missing "_" is some sort
> of mistake, we should strive to follow TRM naming, so grepping so it becomes
> easier to look for informations in these things in the TRM.
>
> Same reason for naming our regulators and pinctrl after the names used in
> device schematics, if available.
>
>
> Heiko
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: rockchip: fix some clocks' name to be more standard style Jianqun Xu <jay.xu@rock-chips.com> - 2016-11-02 08:10 +0100
  Re: [PATCH] clk: rockchip: fix some clocks' name to be more standard  style Shawn Lin <shawn.lin@rock-chips.com> - 2016-11-03 10:00 +0100
    Re: [PATCH] clk: rockchip: fix some clocks' name to be more standard style Heiko Stübner <heiko@sntech.de> - 2016-11-03 15:40 +0100
      Re: [PATCH] clk: rockchip: fix some clocks' name to be more standard  style "jay.xu" <jay.xu@rock-chips.com> - 2016-11-04 01:40 +0100

csiph-web