Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1514085
| From | Michael Scott <michael.scott@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver |
| Date | 2016-11-02 20:20 +0100 |
| Message-ID | <sz9eN-1Ud-11@gated-at.bofh.it> (permalink) |
| References | <synjR-4H2-47@gated-at.bofh.it> <syR8e-6Wq-13@gated-at.bofh.it> <syW7U-1Vz-27@gated-at.bofh.it> <sz8C6-1rE-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11/02/2016 11:36 AM, Stephen Boyd wrote:
> On 11/01, Michael Scott wrote:
>> On 11/01/2016 04:53 PM, Stephen Boyd wrote:
>>> On 10/31, Michael Scott wrote:
>>>> +
>>>> +static const struct msm_pingroup msm8994_groups[] = {
>>>> + PINGROUP(0, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA,
>>>> + NA, NA),
>>> I see an hdmi_rcv group here after blsp_uim1. Please add it for
>>> this gpio.
>> Hi Stephen,
>>
>> Thank you for reviewing the data-- this is really tedious stuff.
>>
>> I'd like to make sure that we're both using tech data for msm8994.
>> I don't see the hdmi_rcv function at all in my docs.
>>
>>>> + PINGROUP(1, blsp_spi1, blsp_uart1, blsp_uim1, NA, NA, NA, NA, NA, NA,
>>>> + NA, NA),
>>>> + PINGROUP(2, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA,
>>>> + NA, NA),
>>>> + PINGROUP(3, blsp_spi1, blsp_uart1, blsp_i2c1, NA, NA, NA, NA, NA, NA,
>>>> + NA, NA),
>>>> + PINGROUP(4, blsp_spi2, blsp_uart2, blsp_uim2, qdss_cti_trig_out_b,
>>>> + NA, NA, NA, NA, NA, NA, NA),
>>>> + PINGROUP(5, blsp_spi2, blsp_uart2, blsp_uim2, qdss_cti_trig_in_b, NA,
>>> The qdss_cti_* is in function 5 for both of these, not function
>>> 4.
>> These are indeed wrong, but my docs both show as function 7.
> Ok. I think your document is for 8994v1, which never got
> commercialized. I certainly see that this function assignment
> changed between v1 and v2 from 7 to 5.
>
> Now that my eyes are bleeding I'm going to do something else.
Thank you for clarifying the issue.
I'll defer to your document for the qti* and hdmi_rcv function settings
for the next patch version.
- Mike
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver Stephen Boyd <sboyd@codeaurora.org> - 2016-11-02 01:00 +0100
Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver Michael Scott <michael.scott@linaro.org> - 2016-11-02 06:20 +0100
Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver Stephen Boyd <sboyd@codeaurora.org> - 2016-11-02 19:40 +0100
Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver Michael Scott <michael.scott@linaro.org> - 2016-11-02 20:20 +0100
Re: [PATCH V4] pinctrl: qcom: Add msm8994 pinctrl driver Jeremy McNicoll <jmcnicol@redhat.com> - 2016-11-03 00:30 +0100
csiph-web