[PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6]

From	Andrew Jeffery <andrew@aj.id.au>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6]
Date	2016-11-02 15:40 +0100
Message-ID	<sz4RP-7vs-5@gated-at.bofh.it> (permalink)
References	<sz4RP-7vs-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

If a pin depending on bit 6 in SCU90 is requested for GPIO, the export
will succeed but changes to the GPIO's value will not be accepted by the
hardware. This is because the pinmux driver has misconfigured the SCU by
writing 1 to the reserved bit.

The description of SCU90[6] from the datasheet is 'Reserved, must keep
at value ”0”'. The fix is to switch pinmux from the bit-flipping macro
to explicitly configuring the .enable and .disable values to zero.

The patch has been tested on an AST2500 EVB.

Fixes: 56e57cb6c07f (pinctrl: Add pinctrl-aspeed-g5 driver)
Reported-by: Uma Yadlapati <yadlapat@us.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
---

This patch should be applied for 4.9.

 drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c
index c8c72e8259d3..87b46390b695 100644
--- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c
+++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c
@@ -26,7 +26,7 @@
 
 #define ASPEED_G5_NR_PINS 228
 
-#define COND1		SIG_DESC_BIT(SCU90, 6, 0)
+#define COND1		{ SCU90, BIT(6), 0, 0 }
 #define COND2		{ SCU94, GENMASK(1, 0), 0, 0 }
 
 #define B14 0
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6] Andrew Jeffery <andrew@aj.id.au> - 2016-11-02 15:40 +0100
  Re: [PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6] Joel Stanley <joel@jms.id.au> - 2016-11-04 00:10 +0100
    Re: [PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6] Linus Walleij <linus.walleij@linaro.org> - 2016-11-07 10:40 +0100
      Re: [PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6] Andrew Jeffery <andrew@aj.id.au> - 2016-11-07 23:50 +0100
  Re: [PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6] Linus Walleij <linus.walleij@linaro.org> - 2016-11-07 10:40 +0100

csiph-web