Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs
Date	2016-11-02 12:00 +0100
Message-ID	<sz1qV-59H-9@gated-at.bofh.it> (permalink)
References	<swjkl-3Pu-1@gated-at.bofh.it> <sx0z0-7iX-1@gated-at.bofh.it> <sxf4Z-hO-5@gated-at.bofh.it> <sxjUZ-3o4-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 28, 2016 at 06:13:08PM +0000, Aaron Miller wrote:

Please do not top-post.

...

>     On Thu, Oct 27, 2016 at 02:33:32PM -0700, Aaron Miller wrote:
>     > The old 'csrowX' sysfs directories had per-csrow error counters, but the
>     > new 'dimmX' directories do not currently expose error counts.
>     > 
>     > EDAC already keeps these counts, add them to sysfs so per-dimm counts
>     > are still available when CONFIG_EDAC_LEGACY_SYSFS=n
>     > 
>     > Signed-off-by: Aaron Miller <aaronmiller@fb.com>
>     > ---

In any case, after looking at Mauro's docs changes:

https://lkml.kernel.org/r/cover.1477765574.git.mchehab@s-opensource.com

you'd need to add those new sysfs files to the "SYSFS INTERFACE" section
of wherever Documentation/edac.txt ends up. I believe it is:

Documentation/{edac.txt => admin-guide/ras.rst}

I believe the easiest would be if you redo this patch ontop of his
changes.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] EDAC: expose per-dimm error counts in sysfs Aaron Miller <aaronmiller@fb.com> - 2016-10-27 23:40 +0200
  Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs Borislav Petkov <bp@alien8.de> - 2016-10-28 15:10 +0200
    Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs Aaron Miller <aaronmiller@fb.com> - 2016-10-28 20:20 +0200
      Re: [PATCH v2] EDAC: expose per-dimm error counts in sysfs Borislav Petkov <bp@alien8.de> - 2016-11-02 12:00 +0100

csiph-web