Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd() and its write pair

From	Ming Lei <tom.leiming@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd() and its write pair
Date	2016-11-01 00:00 +0100
Message-ID	<sytIB-bU-1@gated-at.bofh.it> (permalink)
References	<sxx1U-3GR-3@gated-at.bofh.it> <sxxbA-3Kf-35@gated-at.bofh.it> <sylrH-3r1-1@gated-at.bofh.it> <symxs-47I-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 31, 2016 at 11:11 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Oct 31, 2016 at 09:59:43AM -0400, Theodore Ts'o wrote:
>> What is _rd and _wt supposed to stand for?
>
> I think it's read and write, but I think the naming is highly
> unfortunate.  I started dabbling around with the patches a bit,
> and to keep my sanity a started reaming it to _pages and _bvec
> which is the real semantics - the _rd or _pages gives you a synthetic
> bvec for each page, and the other one gives you the full bvec.

Looks _pages & _bvec is better and still a little confusing and not reflect
its real purpose from user view, since both points to real bvec. Could we
just rename _rd as bio_for_each_segment_all_ro() which means the pointed
bvec is readonly and not introduce _wt?

Thanks,
Ming Lei

Thread

[PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd() and its write pair Ming Lei <tom.leiming@gmail.com> - 2016-10-29 10:30 +0200
  Re: [PATCH 45/60] block: bio: introduce  bio_for_each_segment_all_rd() and its write pair Theodore Ts'o <tytso@mit.edu> - 2016-10-31 15:10 +0100
    Re: [PATCH 45/60] block: bio: introduce  bio_for_each_segment_all_rd() and its write pair Christoph Hellwig <hch@infradead.org> - 2016-10-31 16:20 +0100
      Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd()  and its write pair Ming Lei <tom.leiming@gmail.com> - 2016-11-01 00:00 +0100
      Re: [PATCH 45/60] block: bio: introduce  bio_for_each_segment_all_rd() and its write pair Kent Overstreet <kent.overstreet@gmail.com> - 2016-11-02 04:10 +0100
    Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd()  and its write pair Ming Lei <tom.leiming@gmail.com> - 2016-10-31 23:50 +0100
      Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd()  and its write pair Ming Lei <tom.leiming@gmail.com> - 2016-11-01 01:00 +0100
        Re: [PATCH 45/60] block: bio: introduce  bio_for_each_segment_all_rd() and its write pair Theodore Ts'o <tytso@mit.edu> - 2016-11-01 15:20 +0100
          Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd()  and its write pair Ming Lei <tom.leiming@gmail.com> - 2016-11-02 03:00 +0100

csiph-web