Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query
Date	2016-10-31 22:40 +0100
Message-ID	<systc-7Sy-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <smtbj-2Ad-13@gated-at.bofh.it> <svTzz-3Fg-1@gated-at.bofh.it> <svTSW-43c-15@gated-at.bofh.it> <sweXo-W6-17@gated-at.bofh.it> <syrns-7fi-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon 2016-10-31 13:22:18, Matt Ranostay wrote:
> On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay <mranostay@gmail.com> wrote:
> > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
> >>> Pavel + Sebastian this is the patchset that need I some input on :)
> >>
> >> Better then previous one.
> >>
> >> But my version of bq27xxx_battery.c already contains this:
> >
> > This is for allowing udev rule to set the properties as well.
> > otherwise a kinda crude RUN = " echo value >
> > /sys/module/bq27xxx_battery/parameters/poll_interval" is required.
> 
> Any thoughts on this?
 
I'd say  echo value >
/sys/module/bq27xxx_battery/parameters/poll_interval .. is quite
adequate solution...?

Alternatively, convince us that something else is useful for everyone,
and we can do the right thing (poll more often when battery is nearly
empty), automatically...

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay <matt@ranostay.consulting> - 2016-10-31 21:30 +0100
  Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Pali Rohár <pali.rohar@gmail.com> - 2016-10-31 21:40 +0100
  Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval  property query Pavel Machek <pavel@ucw.cz> - 2016-10-31 22:40 +0100
    Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay <mranostay@gmail.com> - 2016-11-01 21:00 +0100
      Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval  property query Pavel Machek <pavel@ucw.cz> - 2016-11-02 09:30 +0100
        Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay <mranostay@gmail.com> - 2016-11-04 06:10 +0100
          Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval  property query Pavel Machek <pavel@ucw.cz> - 2016-11-04 08:20 +0100
            Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval  property query Tony Lindgren <tony@atomide.com> - 2016-11-04 16:00 +0100
              Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval  property query Pavel Machek <pavel@ucw.cz> - 2016-11-04 21:30 +0100
                Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay <mranostay@gmail.com> - 2016-11-04 21:50 +0100
                Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval  property query Pavel Machek <pavel@ucw.cz> - 2016-11-04 22:50 +0100

csiph-web