Re: [RFC PATCH 0/4] Clean up watchdog handlers

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Babu Moger <babu.moger@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 0/4] Clean up watchdog handlers
Date	Mon, 31 Oct 2016 22:30:01 +0100
Message-ID	<sysjv-7Pf-19@gated-at.bofh.it> (permalink)
References	<swyW6-6ba-21@gated-at.bofh.it> <sys09-7Ib-3@gated-at.bofh.it>
Organization	Oracle Corporation
User-Agent	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
X-Source-IP	aserv0022.oracle.com [141.146.126.234]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	56
X-Original-Cc	mingo@kernel.org, akpm@linux-foundation.org, ak@linux.intel.com, jkosina@suse.cz, baiyaowei@cmss.chinamobile.com, atomlin@redhat.com, uobergfe@redhat.com, tj@kernel.org, hidehiro.kawai.ez@hitachi.com, johunt@akamai.com, davem@davemloft.net, sparclinux@vger.kernel.org, bp@suse.de, bywxiaobai@163.com, cmetcalf@mellanox.com, keescook@chromium.org, ebiederm@xmission.com, huawei.libin@huawei.com, ralf@linux-mips.org, dvyukov@google.com, linux-kernel@vger.kernel.org, sam@ravnborg.org
X-Original-Date	Mon, 31 Oct 2016 16:26:49 -0500
X-Original-Message-ID	<ca118f3f-75f9-365a-93c5-0b1771a022e3@oracle.com>
X-Original-References	<1477497743-15357-1-git-send-email-babu.moger@oracle.com> <20161031210056.GT35881@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1512914

Show key headers only | View raw

On 10/31/2016 4:00 PM, Don Zickus wrote:
> On Wed, Oct 26, 2016 at 09:02:19AM -0700, Babu Moger wrote:
>> This is an attempt to cleanup watchdog handlers. Right now,
>> kernel/watchdog.c implements both softlockup and hardlockup detectors.
>> Softlockup code is generic. Hardlockup code is arch specific. Some
>> architectures don't use hardlockup detectors. They use their own watchdog
>> detectors. To make both these combination work, we have numerous #ifdefs
>> in kernel/watchdog.c.
>>
>> We are trying here to make these handlers independent of each other.
>> Also provide an interface for architectures to implement their own
>> handlers. watchdog_nmi_enable and watchdog_nmi_disable will be defined
>> as weak such that architectures can override its definitions.
>>
>> Thanks to Don Zickus for his suggestions.
>> Here is the previous discussion
>> http://www.spinics.net/lists/sparclinux/msg16441.html
> Hi Babu,
>
> I finally got some cycles to poke at this today.  Good work.  A couple of
> suggestions.  For bisectability, I am thinking patch2 should be first and
> patch1 and patch3 should be combined.  Also watchdog_hld.c is going to need
> up top:
>
> #define pr_fmt(fmt) "NMI watchdog: " fmt
>
> otherwise the error messages miss the header.
>
> Though I don't think watchdog.c and watchdog_hld.c should have the same
> header.  A good solution isn't coming to me right now.  I will try to run
> some tests on this tomorrow.

    Don,  Thanks for the feedback.  Let me know if you into issues with 
your tests. I will start working on the
    review comments.

>
>
> Cheers,
> Don
>
>> Babu Moger (4):
>>    watchdog: Remove hardlockup handler references
>>    watchdog: Move shared definitions to nmi.h
>>    watchdog: Move hardlockup detector in separate file
>>    sparc: Implement watchdog_nmi_enable and watchdog_nmi_disable
>>
>>   arch/sparc/kernel/nmi.c |   44 ++++++++-
>>   include/linux/nmi.h     |   19 ++++
>>   kernel/Makefile         |    1 +
>>   kernel/watchdog.c       |  276 ++---------------------------------------------
>>   kernel/watchdog_hld.c   |  238 ++++++++++++++++++++++++++++++++++++++++
>>   5 files changed, 312 insertions(+), 266 deletions(-)
>>   create mode 100644 kernel/watchdog_hld.c
>>

Thread

Re: [RFC PATCH 0/4] Clean up watchdog handlers Don Zickus <dzickus@redhat.com> - 2016-10-31 22:10 +0100
  Re: [RFC PATCH 0/4] Clean up watchdog handlers Babu Moger <babu.moger@oracle.com> - 2016-10-31 22:30 +0100
  Re: [RFC PATCH 0/4] Clean up watchdog handlers Babu Moger <babu.moger@oracle.com> - 2016-10-31 22:40 +0100
    Re: [RFC PATCH 0/4] Clean up watchdog handlers Don Zickus <dzickus@redhat.com> - 2016-11-01 14:30 +0100
      Re: [RFC PATCH 0/4] Clean up watchdog handlers Babu Moger <babu.moger@oracle.com> - 2016-11-01 16:10 +0100

csiph-web