Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512862

Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file operation

Show all headers | View raw

On Mon, Oct 31, 2016 at 02:07:54PM +0100, Christoph Hellwig wrote:
> On Mon, Oct 31, 2016 at 10:23:31AM +1100, Dave Chinner wrote:
> > This doesn't belong in this patchset.
> 
> It does.  I can't fix up the calling conventions for a methods that
> was never implemented.

That sounds like a problem with your fix - it should work
regardless of whether a valid/implemented AIO function is called
or not, right? There's no difference between an invalid command,
IOCB_CMD_FSYNC where ->aio_fsync() is null, or some supported
command that immediately returns -EIO, the end result should
be the same...

> > Regardless, can we just implement the damned thing rather than
> > removing it?  Plenty of people have asked for it and they still want
> > this functionality. I've sent a couple of different prototypes that
> > worked but got bikeshedded to death, and IIRC Ben also tried to get
> > it implemented but that went nowhere because other parts of his
> > patchset got bikeshedded to death.
> > 
> > If nothing else, just let me implement it in XFS like I did the
> > first time so when all the bikshedding stops we can convert it to
> > the One True AIO Interface that is decided on.
> 
> I'm not going to complain about a proper implementation, but right now
> we don't have any, and I'm not even sure the method signature is
> all that suitable.  E.g. for the in-kernel users we'd really want a 
> ranged fsync like the normal fsync anyway.

You mean like this version I posted a year ago:

https://lkml.org/lkml/2015/10/29/517


Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

aio fixes for use after free and freeze protection Christoph Hellwig <hch@lst.de> - 2016-10-30 17:50 +0100
  [PATCH 3/4] fs: remove aio_run_iocb Christoph Hellwig <hch@lst.de> - 2016-10-30 17:50 +0100
  [PATCH 1/4] aio: hold an extra file reference over AIO read/write operations Christoph Hellwig <hch@lst.de> - 2016-10-30 17:50 +0100
  [PATCH 4/4] aio: fix freeze protection of aio writes Christoph Hellwig <hch@lst.de> - 2016-10-30 17:50 +0100
  [PATCH 2/4] fs: remove the never implemented aio_fsync file operation Christoph Hellwig <hch@lst.de> - 2016-10-30 17:50 +0100
    Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file  operation Dave Chinner <david@fromorbit.com> - 2016-10-31 00:30 +0100
      Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file         operation Christoph Hellwig <hch@lst.de> - 2016-10-31 14:10 +0100
        Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file  operation Dave Chinner <david@fromorbit.com> - 2016-10-31 21:30 +0100
          Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file operation Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-01 02:40 +0100
            Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file         operation Christoph Hellwig <hch@lst.de> - 2016-11-01 15:40 +0100
              Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file operation Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-01 16:10 +0100
          Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file         operation Christoph Hellwig <hch@lst.de> - 2016-11-01 15:30 +0100
  Re: aio fixes for use after free and freeze protection Al Viro <viro@ZenIV.linux.org.uk> - 2016-10-30 18:00 +0100
    Re: aio fixes for use after free and freeze protection Christoph Hellwig <hch@lst.de> - 2016-10-30 18:10 +0100
    Re: aio fixes for use after free and freeze protection Christoph Hellwig <hch@lst.de> - 2016-11-09 03:50 +0100

csiph-web