Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1512699
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 08/12] xen: make use of xenbus_read_unsigned() in xen-pcifront |
| Date | 2016-10-31 17:50 +0100 |
| Message-ID | <synWy-4Wn-29@gated-at.bofh.it> (permalink) |
| References | <synWy-4Wn-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of the read from int to unsigned, but this case has been wrong before: negative values are not allowed for the modified case. Cc: bhelgaas@google.com Cc: linux-pci@vger.kernel.org Signed-off-by: Juergen Gross <jgross@suse.com> --- drivers/pci/xen-pcifront.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index d6ff5e8..8fc2e95 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -1038,10 +1038,8 @@ static int pcifront_detach_devices(struct pcifront_device *pdev) err = -ENOMEM; goto out; } - err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str, "%d", - &state); - if (err != 1) - state = XenbusStateUnknown; + state = xenbus_read_unsigned(pdev->xdev->otherend, str, + XenbusStateUnknown); if (state != XenbusStateClosing) continue; -- 2.6.6
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 08/12] xen: make use of xenbus_read_unsigned() in xen-pcifront Juergen Gross <jgross@suse.com> - 2016-10-31 17:50 +0100 Re: [PATCH 08/12] xen: make use of xenbus_read_unsigned() in xen-pcifront Bjorn Helgaas <helgaas@kernel.org> - 2016-10-31 19:20 +0100
csiph-web