Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger
Date	2016-10-31 16:10 +0100
Message-ID	<symnM-43W-19@gated-at.bofh.it> (permalink)
References	(2 earlier) <syhR7-110-5@gated-at.bofh.it> <syjSV-2kD-11@gated-at.bofh.it> <syjSV-2kD-9@gated-at.bofh.it> <sylBn-3xx-3@gated-at.bofh.it> <symnM-43W-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 31, 2016 at 09:07:24AM -0600, Greg Kroah-Hartman wrote:
> On Mon, Oct 31, 2016 at 09:10:57AM -0500, Rob Herring wrote:
> > On Mon, Oct 31, 2016 at 7:28 AM, Geert Uytterhoeven
> > <geert@linux-m68k.org> wrote:
> > > Hi Greg,
> > >
> > > On Mon, Oct 31, 2016 at 1:21 PM, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > >> On Mon, Oct 31, 2016 at 11:12:45AM +0100, Geert Uytterhoeven wrote:
> > >>> On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote:
> > >>> > The current state of driver removal is not great.
> > >>> > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text
> > >>> > currently undersells exactly how many errors this option will find. Add
> > >>> > a bit more description to indicate this option shouldn't be turned on
> > >>> > unless you actually want to debug driver removal. The text can be
> > >>> > changed later when more drivers are fixed up.
> > >>>
> > >>> Indeed, this is failing miserably for e.g. SoC clock drivers using
> > >>> platform_driver_probe(), which are never retried, rendering the complete
> > >>> system useless.
> > >>
> > >> Why are they never retried?
> > >
> > > Because platform_driver_probe() is meant for non-hotpluggable devices,
> > > and unregisters the platform driver immediately if probe fails.
> > > See also the comments for __platform_driver_probe():
> > 
> > My patch "driver core: skip removal test for non-removable drivers"
> > fixes this case. It seems to have dropped from Greg's queue, so I'll
> > resend.
> 
> Odd, I don't see that anywhere here, sorry about that...

Ah, found it, will queue it up now.

Thread

Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE  stronger Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-31 11:20 +0100
  Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE  stronger Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-31 13:30 +0100
    Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE  stronger Rob Herring <robh@kernel.org> - 2016-10-31 15:20 +0100
      Re: [PATCH] driver core: Make Kconfig text for  DEBUG_TEST_DRIVER_REMOVE stronger Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-31 16:10 +0100
        Re: [PATCH] driver core: Make Kconfig text for  DEBUG_TEST_DRIVER_REMOVE stronger Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-31 16:10 +0100
  Re: [PATCH] driver core: Make Kconfig text for  DEBUG_TEST_DRIVER_REMOVE stronger Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-10-31 13:30 +0100

csiph-web