RE: [PATCH 2/4] isdn/eicon: fix some message formatting errors

From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH 2/4] isdn/eicon: fix some message formatting errors
Date	2016-10-31 14:50 +0100
Message-ID	<syl8l-33q-9@gated-at.bofh.it> (permalink)
References	<sxBoS-6kQ-3@gated-at.bofh.it> <sxBoS-6kQ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Nicolas Iooss
> Sent: 29 October 2016 13:56
> There are some inconsistent debug message formats in message.c. For
> example,
> 
>     dprintf("XDI CAPI: RC cancelled Id:0x02, Ch:%02x", e->Id, ch);
> 
> wrongly reports an ID of 2 and prints the entity ID as the channel ID.
> There are also object pointers which are used instead of the IDs.
> 
> All these inconsistent formats have been found by adding __printf
> attribute to myDbgPrint_...() functions (used by dbug()). As this makes
> the compiler to also complain about using "%ld" with unsigned int values
> (instead of "%u")...

The problem isn’t 'u' <=> 'd' but the 'l'.
They need fixing as well.
It only appears to work because the 64bit architectures pass enough
arguments in registers.

	David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] isdn/eicon: fix some message formatting errors Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-10-29 15:00 +0200
  RE: [PATCH 2/4] isdn/eicon: fix some message formatting errors David Laight <David.Laight@ACULAB.COM> - 2016-10-31 14:50 +0100

csiph-web