Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512512

Re: [PATCH 2/2] mm: remove get_user_pages_locked()

From Paolo Bonzini <pbonzini@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] mm: remove get_user_pages_locked()
Date 2016-10-31 12:50 +0100
Message-ID <syjgd-1Nf-15@gated-at.bofh.it> (permalink)
References <syhHr-V4-7@gated-at.bofh.it> <syhHs-V4-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 31/10/2016 11:02, Lorenzo Stoakes wrote:
> - *
> - * get_user_pages should be phased out in favor of
> - * get_user_pages_locked|unlocked or get_user_pages_fast. Nothing
> - * should use get_user_pages because it cannot pass
> - * FAULT_FLAG_ALLOW_RETRY to handle_mm_fault.

This comment should be preserved in some way.  In addition, removing
get_user_pages_locked() makes it harder (compared to a simple "git grep
-w") to identify callers that lack allow-retry functionality).  So I'm
not sure about the benefits of these patches.

If all callers were changed, then sure removing the _locked suffix would
be a good idea.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mm: remove get_user_pages_locked() Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-31 11:10 +0100
  Re: [PATCH 2/2] mm: remove get_user_pages_locked() Paolo Bonzini <pbonzini@redhat.com> - 2016-10-31 12:50 +0100
    Re: [PATCH 2/2] mm: remove get_user_pages_locked() Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-31 14:50 +0100
      Re: [PATCH 2/2] mm: remove get_user_pages_locked() Paolo Bonzini <pbonzini@redhat.com> - 2016-10-31 19:00 +0100
        Re: [PATCH 2/2] mm: remove get_user_pages_locked() Lorenzo Stoakes <lstoakes@gmail.com> - 2016-10-31 20:30 +0100

csiph-web