Re: [PATCH 1/6] Input: gpio_keys_polled - keep button data constant

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] Input: gpio_keys_polled - keep button data constant
Date	2016-10-31 11:50 +0100
Message-ID	<syika-1bP-7@gated-at.bofh.it> (permalink)
References	<sxoBj-6pf-3@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Fri, Oct 28, 2016 at 04:14:39PM -0700, Dmitry Torokhov wrote:
> diff --git a/include/linux/gpio_keys.h b/include/linux/gpio_keys.h
> index ee2d8c6..d1250ad 100644
> --- a/include/linux/gpio_keys.h
> +++ b/include/linux/gpio_keys.h
> @@ -2,7 +2,6 @@
>  #define _GPIO_KEYS_H
>  
>  struct device;
> -struct gpio_desc;
>  
>  /**
>   * struct gpio_keys_button - configuration parameters
> @@ -31,7 +30,6 @@ struct gpio_keys_button {
>  	bool can_disable;
>  	int value;
>  	unsigned int irq;
> -	struct gpio_desc *gpiod;

Please remove the kernel-doc comment of this member as well.

>  };

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] Input: gpio_keys_polled - keep button data constant Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-29 01:20 +0200
  [PATCH 5/6] Input: gpio_keys - add support for GPIO descriptors Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-29 01:20 +0200
    Re: [PATCH 5/6] Input: gpio_keys - add support for GPIO descriptors Linus Walleij <linus.walleij@linaro.org> - 2016-10-29 10:50 +0200
  [PATCH 6/6] Input: gpio_keys - switch to using generic device properties Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-10-29 01:20 +0200
    Re: [PATCH 6/6] Input: gpio_keys - switch to using generic device  properties Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-10-31 11:50 +0100
  Re: [PATCH 1/6] Input: gpio_keys_polled - keep button data constant Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-10-31 11:50 +0100

csiph-web