Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible
Date	2016-10-31 11:10 +0100
Message-ID	<syhHr-V4-15@gated-at.bofh.it> (permalink)
References	<sv0D7-1uS-7@gated-at.bofh.it> <svKwi-6el-19@gated-at.bofh.it> <svOqd-iC-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 24, 2016 at 04:27:45PM +0200, Daniel Vetter wrote:
> On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote:
> > On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
> > > We get 1 warning when building kernel with W=1:
> > > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
> > > 
> > > In fact, this function is only used in the file in which it is
> > > declared and don't need a declaration, but can be made static.
> > > So this patch marks this function with 'static'.
> > > 
> > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > > 
> > 
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> Applied to drm-misc, thanks.

Argh.  This conflicts with my patch series posted before I went away,
so now we're going to end up with merge conflicts... I suppose you're
happy to handle the conflict as you've bypassed waiting for an ack
from the driver maintainer...

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-10-31 11:10 +0100

csiph-web