Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1512364

Re: [PATCH] cxl: Fix memory allocation failure test

From Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] cxl: Fix memory allocation failure test
Date 2016-10-31 07:20 +0100
Message-ID <sye6R-74m-7@gated-at.bofh.it> (permalink)
References <sy4qR-wo-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 31/10/16 06:35, Christophe JAILLET wrote:
> 'cxl_context_alloc()' does not return an error pointer. It is just a
> shortcut for a call to 'kzalloc' with 'sizeof(struct cxl_context)' as the
> size parameter.
>
> So its return value should be compared with NULL.
> While fixing it, simplify a bit the code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

> ---
> un-compiled because I don't have the required  cross build environment.

Compiles on my system!

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] cxl: Fix memory allocation failure test Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-10-30 21:00 +0100
  Re: [PATCH] cxl: Fix memory allocation failure test walter harms <wharms@bfs.de> - 2016-10-30 21:20 +0100
  Re: [PATCH] cxl: Fix memory allocation failure test Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-10-31 07:20 +0100
  Re: [PATCH] cxl: Fix memory allocation failure test Frederic Barrat <fbarrat@linux.vnet.ibm.com> - 2016-11-02 17:50 +0100

csiph-web