Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512285

Re: [PATCH net] r8152: Fix broken RX checksums.

Show all headers | View raw

On 16-10-30 08:57 PM, David Miller wrote:
> From: Mark Lord <mlord@pobox.com>
> Date: Sun, 30 Oct 2016 19:28:27 -0400
> 
>> The r8152 driver has been broken since (approx) 3.16.xx
>> when support was added for hardware RX checksums
>> on newer chip versions.  Symptoms include random
>> segfaults and silent data corruption over NFS.
>>
>> The hardware checksum logig does not work on the VER_02
>> dongles I have here when used with a slow embedded system CPU.
>> Google reveals others reporting similar issues on Raspberry Pi.
>>
>> So, disable hardware RX checksum support for VER_02, and fix
>> an obvious coding error for IPV6 checksums in the same function.
>>
>> Because this bug results in silent data corruption,
>> it is a good candidate for back-porting to -stable >= 3.16.xx.
>>
>> Signed-off-by: Mark Lord <mlord@pobox.com>
> 
> Applied and queued up for -stable, thanks.

Thanks.  Now that this is taken care of, I do wonder if perhaps
RX checksums ought to be enabled at all for ANY versions of this chip?

My theory is that the checksums probably work okay most of the time,
except when the hardware RX buffer overflows.

In my case, and in the case of the Raspberry Pi, the receiving CPU
is quite a bit slower than mainstream x86, so it can quite easily
fall behind in emptying the RX buffer on the chip.
The only indication this has happened may be an incorrect RX checksum.

This is only a theory, but I otherwise have trouble explaining
why we are seeing invalid RX checksums -- direct cable connections
to a switch, shared only with the NFS server.  No reason for it
to have bad RX checksums in the first place.

Should we just blanket disable RX checksums for all versions here
unless proven otherwise/safe?

Anyone out there know better?

Cheers
Mark

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-10-31 00:30 +0100
  Re: [PATCH net] r8152: Fix broken RX checksums. David Miller <davem@davemloft.net> - 2016-10-31 02:00 +0100
    Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-10-31 03:10 +0100
      Re: [PATCH net] r8152: Fix broken RX checksums. David Miller <davem@davemloft.net> - 2016-10-31 05:00 +0100
        RE: [PATCH net] r8152: Fix broken RX checksums. Hayes Wang <hayeswang@realtek.com> - 2016-10-31 09:20 +0100
          Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-10-31 14:30 +0100
          Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-11-02 19:50 +0100
            Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-11-04 13:20 +0100
          RE: [PATCH net] r8152: Fix broken RX checksums. Hayes Wang <hayeswang@realtek.com> - 2016-11-03 10:00 +0100
            Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-11-03 12:50 +0100
              Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-11-04 15:00 +0100
                Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-11-04 21:30 +0100
              RE: [PATCH net] r8152: Fix broken RX checksums. Hayes Wang <hayeswang@realtek.com> - 2016-11-09 14:20 +0100
                Re: [PATCH net] r8152: Fix broken RX checksums. Mark Lord <mlord@pobox.com> - 2016-11-09 14:20 +0100

csiph-web