Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513744

Re: [PATCH] ASoC: sun4i-codec: Enable bus clock after getting GPIO

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Nov 01, 2016 at 02:31:55PM +0800, Chen-Yu Tsai wrote:
> In the current probe function the GPIO is acquired after the codec's
> bus clock is enabled. However if it fails to acquire the GPIO due to
> a deferred probe, it does not disable the bus clock before bailing out.
> This would result in the clock being enabled multiple times.
> 
> Move the code that enables the bus clock after the part that gets the
> GPIO, maintaining a separation between resource acquisition and device
> enablement in the probe function.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: sun4i-codec: Enable bus clock after getting GPIO Chen-Yu Tsai <wens@csie.org> - 2016-11-01 07:40 +0100
  Re: [PATCH] ASoC: sun4i-codec: Enable bus clock after getting GPIO Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-02 09:50 +0100
  Applied "ASoC: sun4i-codec: Enable bus clock after getting GPIO" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-02 18:00 +0100

csiph-web