Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1513732
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support |
| Date | 2016-11-02 09:30 +0100 |
| Message-ID | <syZ5L-3QA-3@gated-at.bofh.it> (permalink) |
| References | <syZ5L-3QA-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Nov 02, 2016 at 01:18:35AM +0000, Kuninori Morimoto wrote: > + platform = platform_device_register_full(&pdevinfo); > + if (IS_ERR_OR_NULL(platform)) > + return PTR_ERR(platform); This is wrong. If platform is NULL, PTR_ERR() will return zero, which will be interpreted as success. Please, avoid using IS_ERR_OR_NULL(), it leads to exactly this kind of cockup - and it's unnecessary here because platform_device_register_full() does not return NULL. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-02 09:30 +0100 Re: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-11-07 16:00 +0100
csiph-web