RE: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW control

From	"Sricharan" <sricharan@codeaurora.org>
Newsgroups	linux.kernel
Subject	RE: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW control
Date	2016-11-02 08:00 +0100
Message-ID	<syXGF-2Oa-9@gated-at.bofh.it> (permalink)
References	<svKwh-6el-13@gated-at.bofh.it> <svKwi-6el-21@gated-at.bofh.it> <syRBf-7p6-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Stephen,

>On 10/24, Sricharan R wrote:
>> @@ -164,6 +171,10 @@ static int gdsc_enable(struct generic_pm_domain *domain)
>>  	 */
>>  	udelay(1);
>>
>> +	/* Turn on HW trigger mode if supported */
>> +	if (sc->flags & HW_CTRL)
>> +		gdsc_hwctrl(sc, true);
>> +
>
>It sounds like this will cause glitches if the hardware isn't
>asserting their hw control bit by default? This has me concerned
>that we can't just throw the hw control enable part into here,
>because that bit doesn't live in the clock controller, instead it
>lives in the hw block that is powered by the power domain?
>
>Or does the power on reset value of that hw control signal
>asserted? If that's true then we should be ok to force it into hw
>control mode by default.
>

The hw control bit is set by default. Instead its turned 'off'
with the reset value. So it has to not 
be turned 'on' at some point
to put the gdsc in hw control if required. This bit is part of the
gdscr register. So i did not quite understand the reason for the
glitch here ?

Regards,
 Sricharan

Thread

Re: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW  control Stephen Boyd <sboyd@codeaurora.org> - 2016-11-02 01:30 +0100
  RE: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW control "Sricharan" <sricharan@codeaurora.org> - 2016-11-02 08:00 +0100
    RE: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW control "Sricharan" <sricharan@codeaurora.org> - 2016-11-02 08:00 +0100
    Re: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW  control 'Stephen Boyd' <sboyd@codeaurora.org> - 2016-11-02 19:00 +0100
      RE: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW control "Sricharan" <sricharan@codeaurora.org> - 2016-11-03 14:40 +0100
        Re: [PATCH 1/3] clk: qcom: gdsc: Add support for gdscs with HW  control 'Stephen Boyd' <sboyd@codeaurora.org> - 2016-11-03 21:10 +0100

csiph-web