Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513662

Re: [PATCH 1/4] block: add scalable completion tracking of requests

Show all headers | View raw

On Tue, Nov 01 2016, Johannes Thumshirn wrote:
> On Tue, Nov 01, 2016 at 03:05:22PM -0600, Jens Axboe wrote:
> > For legacy block, we simply track them in the request queue. For
> > blk-mq, we track them on a per-sw queue basis, which we can then
> > sum up through the hardware queues and finally to a per device
> > state.
> > 
> > The stats are tracked in, roughly, 0.1s interval windows.
> > 
> > Add sysfs files to display the stats.
> > 
> > Signed-off-by: Jens Axboe <axboe@fb.com>
> > ---
> 
> [...]
> 
> >  
> >  	/* incremented at completion time */
> >  	unsigned long		____cacheline_aligned_in_smp rq_completed[2];
> > +	struct blk_rq_stat	stat[2];
> 
> Can you add an enum or define for the directions? Just 0 and 1 aren't very
> intuitive.

Good point, I added that and updated both the stats patch and the
subsequent blk-mq poll code.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET] block: IO polling improvements Jens Axboe <axboe@fb.com> - 2016-11-01 22:10 +0100
  [PATCH 4/4] blk-mq: make the polling code adaptive Jens Axboe <axboe@fb.com> - 2016-11-01 22:10 +0100
  [PATCH 1/4] block: add scalable completion tracking of requests Jens Axboe <axboe@fb.com> - 2016-11-01 22:10 +0100
    Re: [PATCH 1/4] block: add scalable completion tracking of requests Johannes Thumshirn <jthumshirn@suse.de> - 2016-11-01 23:30 +0100
      Re: [PATCH 1/4] block: add scalable completion tracking of requests Jens Axboe <axboe@kernel.dk> - 2016-11-02 06:40 +0100
    Re: [PATCH 1/4] block: add scalable completion tracking of requests Christoph Hellwig <hch@lst.de> - 2016-11-02 16:00 +0100
    Re: [PATCH 1/4] block: add scalable completion tracking of requests Christoph Hellwig <hch@lst.de> - 2016-11-02 16:00 +0100
    Re: [PATCH 1/4] block: add scalable completion tracking of requests Ming Lei <tom.leiming@gmail.com> - 2016-11-03 12:20 +0100
      Re: [PATCH 1/4] block: add scalable completion tracking of requests Ming Lei <tom.leiming@gmail.com> - 2016-11-03 16:00 +0100
        Re: [PATCH 1/4] block: add scalable completion tracking of requests Ming Lei <tom.leiming@gmail.com> - 2016-11-05 00:20 +0100
          Re: [PATCH 1/4] block: add scalable completion tracking of requests Jens Axboe <axboe@kernel.dk> - 2016-11-05 22:00 +0100
          Re: [PATCH 1/4] block: add scalable completion tracking of requests Jens Axboe <axboe@kernel.dk> - 2016-11-05 22:10 +0100
  [PATCH 2/4] block: move poll code to blk-mq Jens Axboe <axboe@fb.com> - 2016-11-01 22:10 +0100
    Re: [PATCH 2/4] block: move poll code to blk-mq Christoph Hellwig <hch@lst.de> - 2016-11-02 16:00 +0100
  [PATCH 3/4] blk-mq: implement hybrid poll mode for sync O_DIRECT Jens Axboe <axboe@fb.com> - 2016-11-01 22:10 +0100
    Re: [PATCH 3/4] blk-mq: implement hybrid poll mode for sync         O_DIRECT Christoph Hellwig <hch@lst.de> - 2016-11-02 16:00 +0100
    Re: [PATCH 3/4] blk-mq: implement hybrid poll mode for sync O_DIRECT Ming Lei <tom.leiming@gmail.com> - 2016-11-03 13:30 +0100
  Re: [PATCHSET] block: IO polling improvements Christoph Hellwig <hch@lst.de> - 2016-11-02 16:00 +0100

csiph-web