Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513500

Re: [PATCH] net: ip, diag -- Adjust raw_abort to use unlocked __udp_disconnect

Show all headers | View raw

On Tue, 2016-11-01 at 23:05 +0300, Cyrill Gorcunov wrote:
> While being preparing patches for killing raw sockets via
> diag netlink interface I noticed that my runs are stuck:
> 
>  | [root@pcs7 ~]# cat /proc/`pidof ss`/stack
>  | [<ffffffff816d1a76>] __lock_sock+0x80/0xc4
>  | [<ffffffff816d206a>] lock_sock_nested+0x47/0x95
>  | [<ffffffff8179ded6>] udp_disconnect+0x19/0x33
>  | [<ffffffff8179b517>] raw_abort+0x33/0x42
>  | [<ffffffff81702322>] sock_diag_destroy+0x4d/0x52
> 
> which has not been the case before. I narrowed it down to the commit
> 
>  | commit 286c72deabaa240b7eebbd99496ed3324d69f3c0
>  | Author: Eric Dumazet <edumazet@google.com>
>  | Date:   Thu Oct 20 09:39:40 2016 -0700
>  | 
>  |     udp: must lock the socket in udp_disconnect()
> 
> where we start locking the socket for different reason.
> 
> So the raw_abort escaped the renaming and we have to
> fix this typo using __udp_disconnect instead.
> 

The preferred way to cite a bug origin is :

Fixes: 286c72deabaa ("udp: must lock the socket in udp_disconnect()")

> CC: David S. Miller <davem@davemloft.net>
> CC: Eric Dumazet <eric.dumazet@gmail.com>
> CC: David Ahern <dsa@cumulusnetworks.com>
> CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> CC: James Morris <jmorris@namei.org>
> CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> CC: Patrick McHardy <kaber@trash.net>
> CC: Andrey Vagin <avagin@openvz.org>
> CC: Stephen Hemminger <stephen@networkplumber.org>

That is a lot of CC ...

> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>

Acked-by: Eric Dumazet <edumazet@google.com>

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: ip, diag -- Adjust raw_abort to use unlocked  __udp_disconnect Cyrill Gorcunov <gorcunov@gmail.com> - 2016-11-01 21:10 +0100
  Re: [PATCH] net: ip, diag -- Adjust raw_abort to use unlocked  __udp_disconnect Eric Dumazet <eric.dumazet@gmail.com> - 2016-11-01 22:00 +0100
    Re: [PATCH] net: ip, diag -- Adjust raw_abort to use unlocked  __udp_disconnect Cyrill Gorcunov <gorcunov@gmail.com> - 2016-11-01 22:00 +0100
  Re: [PATCH] net: ip, diag -- Adjust raw_abort to use unlocked  __udp_disconnect David Miller <davem@davemloft.net> - 2016-11-02 20:30 +0100

csiph-web