[PATCH] EFI loader: remove dead code

From	Eugene Korenevsky <ekorenevsky@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] EFI loader: remove dead code
Date	2016-11-01 18:40 +0100
Message-ID	<syLct-3dm-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

*e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()').
Therefore the 'if' condition is always false and the entire 'if' statement is
pointless. Remove it.

---
 arch/x86/boot/compressed/eboot.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index cc69e37..edfd4d6 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -956,12 +956,6 @@ static efi_status_t alloc_e820ext(u32 nr_desc, struct setup_data **e820ext,
 	size = sizeof(struct setup_data) +
 		sizeof(struct e820entry) * nr_desc;
 
-	if (*e820ext) {
-		efi_call_early(free_pool, *e820ext);
-		*e820ext = NULL;
-		*e820ext_size = 0;
-	}
-
 	status = efi_call_early(allocate_pool, EFI_LOADER_DATA,
 				size, (void **)e820ext);
 	if (status == EFI_SUCCESS)
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] EFI loader: remove dead code Eugene Korenevsky <ekorenevsky@gmail.com> - 2016-11-01 18:40 +0100
  Re: [PATCH] EFI loader: remove dead code Linn Crosetto <linn@hpe.com> - 2016-11-02 00:10 +0100
    Re: [PATCH] EFI loader: remove dead code Eugene Korenevsky <ekorenevsky@gmail.com> - 2016-11-02 07:00 +0100

csiph-web