Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1513377

Re: block device direct I/O fast path

Show all headers | View raw

On Mon, Oct 31 2016, Christoph Hellwig wrote:
> Hi Jens,
> 
> this small series adds a fasth path to the block device direct I/O
> code.  It uses new magic created by Kent to avoid allocating an array
> for the pages, and as part of that allows small, non-aio direct I/O
> requests to be done without memory allocations or atomic ops and with
> a minimal cache footprint.  It's basically a cut down version of the
> new iomap direct I/O code, and in the future it might also make sense
> to move the main direct I/O code to a similar model.  But indepedent
> of that it's always worth to optimize the case of small, non-I/O
> requests as allocating the bio and biovec on stack and a trivial
> completion handler will always win over a full blown implementation.

I'm not particularly tied to the request based implementation that I did
here:

http://git.kernel.dk/cgit/linux-block/log/?h=blk-dio

I basically wanted to solve two problems with that:

1) The slow old direct-io.c code
2) Implement the hybrid polling

#1 is accomplished with your code as well, though it does lack suppor
for async IO, but that would not be hard to add.

#2 is a bit more problematic, I'm pondering how we can implement that on
top of the bio approach. The nice thing about the request based approach
is that we have a 1:1 mapping with the unit on the driver side. And we
have a place to store the timer. I don't particularly love the embedded
timer, however, it'd be great to implement that differently. Trying to
think of options there, haven't found any yet.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

block device direct I/O fast path Christoph Hellwig <hch@lst.de> - 2016-10-31 19:00 +0100
  [PATCH 2/2] block: fast-path for small and simple direct I/O requests Christoph Hellwig <hch@lst.de> - 2016-10-31 19:00 +0100
    Re: [PATCH 2/2] block: fast-path for small and simple direct I/O  requests Omar Sandoval <osandov@osandov.com> - 2016-11-01 00:30 +0100
      Re: [PATCH 2/2] block: fast-path for small and simple direct I/O         requests Christoph Hellwig <hch@lst.de> - 2016-11-01 15:20 +0100
  [PATCH 1/2] block: add bio_iov_iter_get_pages() Christoph Hellwig <hch@lst.de> - 2016-10-31 19:10 +0100
    Re: [PATCH 1/2] block: add bio_iov_iter_get_pages() Ming Lei <tom.leiming@gmail.com> - 2016-11-01 02:10 +0100
      Re: [PATCH 1/2] block: add bio_iov_iter_get_pages() Christoph Hellwig <hch@lst.de> - 2016-11-01 15:20 +0100
  Re: block device direct I/O fast path Jens Axboe <axboe@kernel.dk> - 2016-11-01 18:10 +0100
    Re: block device direct I/O fast path Christoph Hellwig <hch@lst.de> - 2016-11-01 18:10 +0100
      Re: block device direct I/O fast path Jens Axboe <axboe@kernel.dk> - 2016-11-01 19:00 +0100
        Re: block device direct I/O fast path Jens Axboe <axboe@kernel.dk> - 2016-11-01 19:30 +0100

csiph-web