Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

From	cov@codeaurora.org
Newsgroups	linux.kernel
Subject	Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors
Date	2016-11-01 14:10 +0100
Message-ID	<syGZb-G3-13@gated-at.bofh.it> (permalink)
References	<sjTEZ-3sy-3@gated-at.bofh.it> <sjYlk-6tw-5@gated-at.bofh.it> <sysMy-7ZA-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Bjorn,

On 2016-10-31 15:48, Bjorn Helgaas wrote:
> On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote:
>> The Qualcomm Technologies QDF2432 SoC does not support accesses 
>> smaller
>> than 32 bits to the PCI configuration space. Register the appropriate
>> quirk.
>> 
>> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> 
> Hi Christopher,
> 
> Can you rebase this against v4.9-rc1?  It no longer applies to my tree.

I apologize for not being clearer. This patch depends on:

PCI/ACPI: Extend pci_mcfg_lookup() responsibilities
PCI/ACPI: Check platform-specific ECAM quirks

These patches from Tomasz Nowicki were previously in your pci/ecam-v6
branch, but that seems to have come and gone. How would you like to
proceed?

> Note that this hardware is not spec-compliant since it doesn't support
> sub-32 bit config writes.  I just proposed a patch to warn about that
> [1], so if/when we merge that patch and this one, you'll start seeing
> those warnings.
> 
> [1]
> http://lkml.kernel.org/r/20161031213902.6340.96123.stgit@bhelgaas-glaptop.roam.corp.google.com

That looks great, thank you. The earlier PCI HDL and SoC vendors can be
made aware of such problems, the better.

Thanks,
Cov

Thread

Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-10-31 23:00 +0100
  Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors cov@codeaurora.org - 2016-11-01 14:10 +0100
    Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-02 17:10 +0100
      Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Sinan Kaya <okaya@codeaurora.org> - 2016-11-02 17:40 +0100
        Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-03 15:10 +0100
          Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Sinan Kaya <okaya@codeaurora.org> - 2016-11-03 18:00 +0100
            Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Sinan Kaya <okaya@codeaurora.org> - 2016-11-03 18:10 +0100
            Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-03 21:50 +0100
              Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Sinan Kaya <okaya@codeaurora.org> - 2016-11-04 00:50 +0100
      Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-02 17:50 +0100
      Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Christopher Covington <cov@codeaurora.org> - 2016-11-09 20:30 +0100
        Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-09 21:10 +0100
          Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-09 21:30 +0100
            Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-10 00:00 +0100
              Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-11-10 11:30 +0100
                Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-11-10 15:00 +0100
                Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors Bjorn Helgaas <helgaas@kernel.org> - 2016-11-10 18:50 +0100

csiph-web