RE: [PATCH v3 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE() of nps400 timer

From	Noam Camus <noamca@mellanox.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v3 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE() of nps400 timer
Date	2016-11-01 10:30 +0100
Message-ID	<syDyh-6N8-17@gated-at.bofh.it> (permalink)
References	<syoSB-5vG-9@gated-at.bofh.it> <syoSB-5vG-11@gated-at.bofh.it> <syoSB-5vG-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Thomas Gleixner [mailto:tglx@linutronix.de] 
> Sent: Monday, October 31, 2016 7:40 PM

>>  
>>  static unsigned long nps_timer_rate;
>> +static int nps_get_timer_clk(struct device_node *node,
>
>Please don't glue variables and functions together w/o a new line. That's horrible to read.
Will be fixed in V4

>> +static int __init nps_setup_clocksource(struct device_node *node)
>>  {
>>  	int ret, cluster;
>> +	struct clk *clk;
>>  
>>  	for (cluster = 0; cluster < NPS_CLUSTER_NUM; cluster++)
>>  		nps_msu_reg_low_addr[cluster] =
>>  			nps_host_reg((cluster << NPS_CLUSTER_OFFSET),
>>  				 NPS_MSU_BLKID, NPS_MSU_TICK_LOW);
>>  
>> -	ret = clk_prepare_enable(clk);
>> -	if (ret) {
>> -		pr_err("Couldn't enable parent clock\n");
>> -		return ret;
>> -	}
>> -
>> -	nps_timer_rate = clk_get_rate(clk);
>> +	nps_get_timer_clk(node, &nps_timer_rate, clk);

>Why are you ignoring the return code? It was handled before your change ...
Will be fixed in V4

Regards,
Noam

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE()  of nps400 timer Thomas Gleixner <tglx@linutronix.de> - 2016-10-31 18:50 +0100
  RE: [PATCH v3 2/3] clocksource: update "fn" at  CLOCKSOURCE_OF_DECLARE() of nps400 timer Noam Camus <noamca@mellanox.com> - 2016-11-01 10:30 +0100

csiph-web