Re: [PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

From	Rafał Miłecki <zajec5@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC
Date	2016-11-01 08:40 +0100
Message-ID	<syBPQ-5DN-11@gated-at.bofh.it> (permalink)
References	<syBG9-5AA-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 1 November 2016 at 08:24, John Heenan <john@zgus.com> wrote:
> @@ -5779,6 +5779,12 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw)
>
>         ret = 0;
>
> +       if(priv->fops == &rtl8723bu_fops) {

OK, let me be the first. Documentation/CodingStyle also says to use
space between "if" and "(" ;)


> @@ -6080,9 +6086,11 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
>                 goto exit;
>         }
>
> -       ret = rtl8xxxu_init_device(hw);
> -       if (ret)
> -               goto exit;
> +       if(priv->fops != &rtl8723bu_fops) {

Same here.

I reviewed style only.

-- 
Rafał

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu  wireless IC John Heenan <john@zgus.com> - 2016-11-01 08:30 +0100
  Re: [PATCH v2] rtl8xxxu: Fix for agressive power saving by rtl8723bu  wireless IC Rafał Miłecki <zajec5@gmail.com> - 2016-11-01 08:40 +0100

csiph-web