Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1512255

[PATCH v4 5/6] perf report: Show branch info in callchain entry for browser mode

Show all headers | View raw

If the branch is 100% predicated then the "predicated" is hide.
Similarly, if there is no branch tsx abort, the "abort" is hide.
There is only cycles shown (cycle is supported on skylake platform,
older platform would be 0).

If no iterations, the "iterations" is hide.

Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
---
 tools/perf/ui/browsers/hists.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 84f5dd2..66676cb 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -738,6 +738,7 @@ static int hist_browser__show_callchain_list(struct hist_browser *browser,
 					     struct callchain_print_arg *arg)
 {
 	char bf[1024], *alloc_str;
+	char buf[64], *alloc_str2;
 	const char *str;
 
 	if (arg->row_offset != 0) {
@@ -746,12 +747,26 @@ static int hist_browser__show_callchain_list(struct hist_browser *browser,
 	}
 
 	alloc_str = NULL;
+	alloc_str2 = NULL;
+
 	str = callchain_list__sym_name(chain, bf, sizeof(bf),
 				       browser->show_dso);
 
-	if (need_percent) {
-		char buf[64];
+	if (symbol_conf.show_branchflag_count) {
+		if (need_percent)
+			callchain_list_counts__printf_value(node, chain, NULL,
+							    buf, sizeof(buf));
+		else
+			callchain_list_counts__printf_value(NULL, chain, NULL,
+							    buf, sizeof(buf));
+
+		if (asprintf(&alloc_str2, "%s%s", str, buf) < 0)
+			str = "Not enough memory!";
+		else
+			str = alloc_str2;
+	}
 
+	if (need_percent) {
 		callchain_node__scnprintf_value(node, buf, sizeof(buf),
 						total);
 
@@ -764,6 +779,7 @@ static int hist_browser__show_callchain_list(struct hist_browser *browser,
 	print(browser, chain, str, offset, row, arg);
 
 	free(alloc_str);
+	free(alloc_str2);
 	return 1;
 }
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Jin Yao <yao.jin@linux.intel.com> - 2016-10-31 02:20 +0100
  [PATCH v4 5/6] perf report: Show branch info in callchain entry for browser mode Jin Yao <yao.jin@linux.intel.com> - 2016-10-31 02:20 +0100
  [PATCH v4 4/6] perf report: Show branch info in callchain entry for stdio mode Jin Yao <yao.jin@linux.intel.com> - 2016-10-31 02:30 +0100
  [PATCH v4 1/6] perf report: Add branch flag to callchain cursor node Jin Yao <yao.jin@linux.intel.com> - 2016-10-31 02:30 +0100
  [PATCH v4 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history Jin Yao <yao.jin@linux.intel.com> - 2016-10-31 02:30 +0100
  [PATCH v4 3/6] perf report: Caculate and return the branch flag counting Jin Yao <yao.jin@linux.intel.com> - 2016-10-31 02:30 +0100
  [PATCH v4 2/6] perf report: Create a symbol_conf flag for showing branch flag counting Jin Yao <yao.jin@linux.intel.com> - 2016-10-31 02:30 +0100

csiph-web