Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs
Date	Sun, 30 Oct 2016 20:30:01 +0100
Message-ID	<sy3XP-ms-13@gated-at.bofh.it> (permalink)
References	<sxJw5-3Ir-9@gated-at.bofh.it> <sxJw5-3Ir-7@gated-at.bofh.it>
X-Original-To	Joel Holdsworth <joel@airwebreathe.org.uk>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=uzvrBf38Smwp/fCga4Zja4FJyvDNGodfLNEyEJJcOlI=; b=BdWl1H12qixQOa0BDnv5eO75Em3tj4CYuBoH0JRcoIRbtCtN516cN0Lbs3dkXrSKH9 qKQNtMLtrNNMEAQ5BAI08oQeMMh5msFNGudVhMdEUTok/mBdjHmEK3doj7aHMSztec/9 5w0s5SoBs+4KE/EGx64intIPcH0kPUGv+csyGK8a4BhGGlCxgkLYV5C1/qj39ktHlQIK i8DeBV+tbPSGXAyS0qZwAJeTvwaDT6wZvi+9w6Rb23BK6o6X15/r0HIVdTTuv5nT95at goyJ49EbNCL8A8mUcvw2b/FDGKJBUp/kM2gKcyPUCCKRrTAEymcpKGR+VFWJx2+CbRxN a6fg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=uzvrBf38Smwp/fCga4Zja4FJyvDNGodfLNEyEJJcOlI=; b=JxX4jO7xmy+aN3QdDy7dKm7zhVy73/R0thzAzFKp3Z18jVJ7lM6FuL1/cNxZmh7Xo7 7dQ5twKAigx0qZsKCv+vKyaBB1fzCXr1++p1NkTvGFwUXj/eRmQlsyJMeN52gVi7wbAM KnP1K2PKjBg/mECx2KwaR1OaJ4UfsbOdGL/0VNUHOoeoJLvv1vZArtceGx4uH8Uk2gzw UlOky4zJYuovngz2ZnypCgisDVpqazNkMRU0UcYwhqXdFU/ioZsIbVYzCoBDmTaPlI/q lLzDlemUDGdeMkMauzOLQyyG8BdXJ9f+C+Rm/chyJNCnhJ/9wmHcyuzSVavXic2wT7wt BYnw==
X-Gm-Message-State	ABUngve/lS7xQhExoar+zSiKUsUVns7m6AqfqjNY2U3uTQ+6OKLgEa+bL9MIvaNHj/4jAZ4YQ2U10/jcSEZl0A==
X-Received	by 10.36.175.83 with SMTP id l19mr6041043iti.48.1477855528241; Sun, 30 Oct 2016 12:25:28 -0700 (PDT)
MIME-Version	1.0
X-Google-Sender-Auth	_fHyy7kZy-DZZWMg_1kCV7_3Jrg
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	atull@opensource.altera.com, moritz.fischer@ettus.com, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-spi <linux-spi@vger.kernel.org>
X-Original-Date	Sun, 30 Oct 2016 20:25:27 +0100
X-Original-Message-ID	<CAMuHMdWJYrUp2Bqh6PW7KCEv16HYpvKXG9dAQBjfw+pMxDQd_A@mail.gmail.com>
X-Original-References	<1477776746-3678-1-git-send-email-joel@airwebreathe.org.uk> <1477776746-3678-2-git-send-email-joel@airwebreathe.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1512177

Show key headers only | View raw

On Sat, Oct 29, 2016 at 11:32 PM, Joel Holdsworth
<joel@airwebreathe.org.uk> wrote:
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/lattice-ice40-fpga-mgr.txt
> @@ -0,0 +1,23 @@

> +- cdone-gpio:          GPIO connected to CDONE pin
> +- creset_b-gpio:       GPIO connected to CRESET_B pin. Note that CRESET_B is
> +                       treated as an active-low output because the signal is
> +                       treated as an enable signal, rather than a reset. This
> +                       is necessary because the FPGA will enter Master SPI
> +                       mode and drive SCK with a clock signal, potentially
> +                       jamming other devices on the bus, unless CRESET_B is
> +                       held high until the firmware is loaded.

Plural, please, like in the previous version, cfr.
Documentation/devicetree/bindings/gpio/gpio.txt:
"GPIO properties should be named "[<name>-]gpios", with <name> being the purpose
 of this GPIO for the device. While a non-existent <name> is considered valid
 for compatibility reasons (resolving to the "gpios" property), it is
not allowed
 for new bindings. Also, GPIO properties named "[<name>-]gpio" are valid and old
 bindings use it, but are only supported for compatibility reasons and
should not
 be used for newer bindings since it has been deprecated."

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs Joel Holdsworth <joel@airwebreathe.org.uk> - 2016-10-29 23:40 +0200
  Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-30 20:30 +0100
    Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs Joel Holdsworth <joel@airwebreathe.org.uk> - 2016-10-30 22:40 +0100
  Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs Rob Herring <robh@kernel.org> - 2016-10-31 07:40 +0100
    Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs Joel Holdsworth <joel@airwebreathe.org.uk> - 2016-10-31 18:00 +0100
      Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs Moritz Fischer <moritz.fischer@ettus.com> - 2016-10-31 18:10 +0100
      Re: [PATCH v4 2/2] fpga: Add support for Lattice iCE40 FPGAs Rob Herring <robh@kernel.org> - 2016-10-31 22:30 +0100

csiph-web